From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41191C2D0DA for ; Wed, 25 Dec 2019 07:18:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D4BE20722 for ; Wed, 25 Dec 2019 07:18:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726397AbfLYHSk (ORCPT ); Wed, 25 Dec 2019 02:18:40 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:59306 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbfLYHSk (ORCPT ); Wed, 25 Dec 2019 02:18:40 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D481A154E95E1; Tue, 24 Dec 2019 23:18:38 -0800 (PST) Date: Tue, 24 Dec 2019 23:18:35 -0800 (PST) Message-Id: <20191224.231835.1355628010065210167.davem@davemloft.net> To: mkubecek@suse.cz Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, jiri@resnulli.us, andrew@lunn.ch, f.fainelli@gmail.com, linville@tuxdriver.com, stephen@networkplumber.org, johannes@sipsolutions.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v8 00/14] ethtool netlink interface, part 1 From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Dec 2019 23:18:39 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kubecek Date: Mon, 23 Dec 2019 00:45:14 +0100 (CET) > This is first part of netlink based alternative userspace interface for > ethtool. It aims to address some long known issues with the ioctl > interface, mainly lack of extensibility, raciness, limited error reporting > and absence of notifications. The goal is to allow userspace ethtool > utility to provide all features it currently does but without using the > ioctl interface. However, some features provided by ethtool ioctl API will > be available through other netlink interfaces (rtnetlink, devlink) if it's > more appropriate. ... Please address the feedback for patch #3 (especially the u32-->u8 thing) and then this series should be good to go! Thanks!