* [PATCH v3 1/3] dt-bindings: Add vendor prefix for Satoz
@ 2019-12-24 14:19 Miquel Raynal
2019-12-24 14:19 ` [PATCH v3 2/3] dt-bindings: display: Add Satoz panel Miquel Raynal
2019-12-24 14:19 ` [PATCH v3 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Miquel Raynal
0 siblings, 2 replies; 6+ messages in thread
From: Miquel Raynal @ 2019-12-24 14:19 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
Cc: Rob Herring, Mark Rutland, devicetree, linux-kernel, dri-devel,
Paul Kocialkowski, Maxime Chevallier, Thomas Petazzoni,
Miquel Raynal, Rob Herring
Satoz is a Chinese TFT manufacturer.
Website: http://www.sat-sz.com/English/index.html
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes since v2:
* None.
Changes since v1:
* Added Rob's Ack.
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 967e78c5ec0a..4894c5314b49 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -819,6 +819,8 @@ patternProperties:
description: Sancloud Ltd
"^sandisk,.*":
description: Sandisk Corporation
+ "^satoz,.*":
+ description: Satoz International Co., Ltd
"^sbs,.*":
description: Smart Battery System
"^schindler,.*":
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 2/3] dt-bindings: display: Add Satoz panel
2019-12-24 14:19 [PATCH v3 1/3] dt-bindings: Add vendor prefix for Satoz Miquel Raynal
@ 2019-12-24 14:19 ` Miquel Raynal
2020-01-04 0:09 ` Rob Herring
2019-12-24 14:19 ` [PATCH v3 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Miquel Raynal
1 sibling, 1 reply; 6+ messages in thread
From: Miquel Raynal @ 2019-12-24 14:19 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
Cc: Rob Herring, Mark Rutland, devicetree, linux-kernel, dri-devel,
Paul Kocialkowski, Maxime Chevallier, Thomas Petazzoni,
Miquel Raynal
Satoz is a Chinese TFT manufacturer.
Website: http://www.sat-sz.com/English/index.html
Add (simple) bindings for its SAT050AT40H12R2 5.0 inch LCD panel.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
Changes since v2:
* None.
Changes since v1:
* New patch
.../display/panel/satoz,sat050at40h12r2.yaml | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
new file mode 100644
index 000000000000..567b32a544f3
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
@@ -0,0 +1,27 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/satoz,sat050at40h12r2#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Satoz SAT050AT40H12R2 panel
+
+maintainers:
+ - Thierry Reding <thierry.reding@gmail.com>
+
+description: |+
+ LCD 5.0 inch 800x480 RGB panel.
+
+ This binding is compatible with the simple-panel binding, which is specified
+ in simple-panel.txt in this directory.
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ contains:
+ const: satoz,sat050at40h12r2
+
+required:
+ - compatible
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support
2019-12-24 14:19 [PATCH v3 1/3] dt-bindings: Add vendor prefix for Satoz Miquel Raynal
2019-12-24 14:19 ` [PATCH v3 2/3] dt-bindings: display: Add Satoz panel Miquel Raynal
@ 2019-12-24 14:19 ` Miquel Raynal
2020-01-04 15:18 ` Sam Ravnborg
1 sibling, 1 reply; 6+ messages in thread
From: Miquel Raynal @ 2019-12-24 14:19 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
Cc: Rob Herring, Mark Rutland, devicetree, linux-kernel, dri-devel,
Paul Kocialkowski, Maxime Chevallier, Thomas Petazzoni,
Miquel Raynal
Add support for the Satoz SAT050AT40H12R2 RGB panel.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
Changes since v2:
* Dropped two uneeded lines which would fail the build.
Changes since v1:
* Switched to display_timing's instead of display_mode.
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index ac6f6b5d200d..cc1595c5633a 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2559,6 +2559,29 @@ static const struct panel_desc samsung_ltn140at29_301 = {
},
};
+static const struct display_timing satoz_sat050at40h12r2_timing = {
+ .pixelclock = { 33300000, 33300000, 50000000 },
+ .hactive = {800, 800, 800},
+ .hfront_porch = {16, 210, 354},
+ .hback_porch = {46, 46, 46},
+ .hsync_len = {1, 1, 40},
+ .vactive = {480, 480, 480},
+ .vfront_porch = {7, 22, 147},
+ .vback_porch = {23, 23, 23},
+ .vsync_len = {1, 1, 20},
+};
+
+static const struct panel_desc satoz_sat050at40h12r2 = {
+ .timings = &satoz_sat050at40h12r2_timing,
+ .num_timings = 1,
+ .bpc = 8,
+ .size = {
+ .width = 108,
+ .height = 65,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+};
+
static const struct drm_display_mode sharp_ld_d5116z01b_mode = {
.clock = 168480,
.hdisplay = 1920,
@@ -3354,6 +3377,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "samsung,ltn140at29-301",
.data = &samsung_ltn140at29_301,
+ }, {
+ .compatible = "satoz,sat050at40h12r2",
+ .data = &satoz_sat050at40h12r2,
}, {
.compatible = "sharp,ld-d5116z01b",
.data = &sharp_ld_d5116z01b,
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/3] dt-bindings: display: Add Satoz panel
2019-12-24 14:19 ` [PATCH v3 2/3] dt-bindings: display: Add Satoz panel Miquel Raynal
@ 2020-01-04 0:09 ` Rob Herring
2020-01-06 9:54 ` Miquel Raynal
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2020-01-04 0:09 UTC (permalink / raw)
To: Miquel Raynal
Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Mark Rutland, devicetree, linux-kernel, dri-devel,
Paul Kocialkowski, Maxime Chevallier, Thomas Petazzoni
On Tue, Dec 24, 2019 at 03:19:04PM +0100, Miquel Raynal wrote:
> Satoz is a Chinese TFT manufacturer.
> Website: http://www.sat-sz.com/English/index.html
>
> Add (simple) bindings for its SAT050AT40H12R2 5.0 inch LCD panel.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>
> Changes since v2:
> * None.
>
> Changes since v1:
> * New patch
>
> .../display/panel/satoz,sat050at40h12r2.yaml | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
Note that this may become obsolete if we move all simple panels to a
single schema.
>
> diff --git a/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
> new file mode 100644
> index 000000000000..567b32a544f3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/satoz,sat050at40h12r2#
Missing '.yaml'
Run 'make dt_binding_check' which will check this and other things.
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Satoz SAT050AT40H12R2 panel
> +
> +maintainers:
> + - Thierry Reding <thierry.reding@gmail.com>
> +
> +description: |+
> + LCD 5.0 inch 800x480 RGB panel.
Any public spec for this panel?
> +
> + This binding is compatible with the simple-panel binding, which is specified
> + in simple-panel.txt in this directory.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + contains:
Drop 'contains'. It must be exactly the below string, not the below
string and *any* other strings.
> + const: satoz,sat050at40h12r2
> +
> +required:
> + - compatible
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support
2019-12-24 14:19 ` [PATCH v3 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Miquel Raynal
@ 2020-01-04 15:18 ` Sam Ravnborg
0 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2020-01-04 15:18 UTC (permalink / raw)
To: Miquel Raynal
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland, devicetree, linux-kernel, dri-devel,
Paul Kocialkowski, Maxime Chevallier, Thomas Petazzoni
Hi Miquel.
On Tue, Dec 24, 2019 at 03:19:05PM +0100, Miquel Raynal wrote:
> Add support for the Satoz SAT050AT40H12R2 RGB panel.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>
> Changes since v2:
> * Dropped two uneeded lines which would fail the build.
>
> Changes since v1:
> * Switched to display_timing's instead of display_mode.
>
> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index ac6f6b5d200d..cc1595c5633a 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2559,6 +2559,29 @@ static const struct panel_desc samsung_ltn140at29_301 = {
> },
> };
>
> +static const struct display_timing satoz_sat050at40h12r2_timing = {
> + .pixelclock = { 33300000, 33300000, 50000000 },
> + .hactive = {800, 800, 800},
> + .hfront_porch = {16, 210, 354},
> + .hback_porch = {46, 46, 46},
> + .hsync_len = {1, 1, 40},
> + .vactive = {480, 480, 480},
> + .vfront_porch = {7, 22, 147},
> + .vback_porch = {23, 23, 23},
> + .vsync_len = {1, 1, 20},
> +};
> +
> +static const struct panel_desc satoz_sat050at40h12r2 = {
> + .timings = &satoz_sat050at40h12r2_timing,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 108,
> + .height = 65,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +};
Please add connector_type as well.
This is mandatory for all new panels.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/3] dt-bindings: display: Add Satoz panel
2020-01-04 0:09 ` Rob Herring
@ 2020-01-06 9:54 ` Miquel Raynal
0 siblings, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2020-01-06 9:54 UTC (permalink / raw)
To: Rob Herring
Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Mark Rutland, devicetree, linux-kernel, dri-devel,
Paul Kocialkowski, Maxime Chevallier, Thomas Petazzoni
Hi Rob,
Rob Herring <robh@kernel.org> wrote on Fri, 3 Jan 2020 17:09:57 -0700:
> On Tue, Dec 24, 2019 at 03:19:04PM +0100, Miquel Raynal wrote:
> > Satoz is a Chinese TFT manufacturer.
> > Website: http://www.sat-sz.com/English/index.html
> >
> > Add (simple) bindings for its SAT050AT40H12R2 5.0 inch LCD panel.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >
> > Changes since v2:
> > * None.
> >
> > Changes since v1:
> > * New patch
> >
> > .../display/panel/satoz,sat050at40h12r2.yaml | 27 +++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
>
> Note that this may become obsolete if we move all simple panels to a
> single schema.
Absolutely.
>
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
> > new file mode 100644
> > index 000000000000..567b32a544f3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
> > @@ -0,0 +1,27 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/satoz,sat050at40h12r2#
>
> Missing '.yaml'
>
> Run 'make dt_binding_check' which will check this and other things.
Right, corrected.
>
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Satoz SAT050AT40H12R2 panel
> > +
> > +maintainers:
> > + - Thierry Reding <thierry.reding@gmail.com>
> > +
> > +description: |+
> > + LCD 5.0 inch 800x480 RGB panel.
>
> Any public spec for this panel?
Unfortunately, no. I mentioned it in the v3.
>
> > +
> > + This binding is compatible with the simple-panel binding, which is specified
> > + in simple-panel.txt in this directory.
> > +
> > +allOf:
> > + - $ref: panel-common.yaml#
> > +
> > +properties:
> > + compatible:
> > + contains:
>
> Drop 'contains'. It must be exactly the below string, not the below
> string and *any* other strings.
Ok.
>
> > + const: satoz,sat050at40h12r2
> > +
> > +required:
> > + - compatible
> > --
> > 2.20.1
> >
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-06 9:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-24 14:19 [PATCH v3 1/3] dt-bindings: Add vendor prefix for Satoz Miquel Raynal
2019-12-24 14:19 ` [PATCH v3 2/3] dt-bindings: display: Add Satoz panel Miquel Raynal
2020-01-04 0:09 ` Rob Herring
2020-01-06 9:54 ` Miquel Raynal
2019-12-24 14:19 ` [PATCH v3 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Miquel Raynal
2020-01-04 15:18 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).