From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE9C0C2D0C3 for ; Sat, 28 Dec 2019 00:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 862A020828 for ; Sat, 28 Dec 2019 00:32:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726088AbfL1AcT (ORCPT ); Fri, 27 Dec 2019 19:32:19 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:53730 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbfL1AcS (ORCPT ); Fri, 27 Dec 2019 19:32:18 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 22BA5154D114C; Fri, 27 Dec 2019 16:32:18 -0800 (PST) Date: Fri, 27 Dec 2019 16:32:17 -0800 (PST) Message-Id: <20191227.163217.1055599246835779278.davem@davemloft.net> To: maowenan@huawei.com Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, linux@rempel-privat.de, marek.behun@nic.cz, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_init From: David Miller In-Reply-To: <20191224115812.166927-1-maowenan@huawei.com> References: <20191224112515.GE3395@lunn.ch> <20191224115812.166927-1-maowenan@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Dec 2019 16:32:18 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mao Wenan Date: Tue, 24 Dec 2019 19:58:12 +0800 > There is no need to set variable 'mbus' static > since new value always be assigned before use it. > > Signed-off-by: Mao Wenan Applied, thank you.