From: David Miller <davem@davemloft.net>
To: nikita.yoush@cogentembedded.com
Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
cphealy@gmail.com, l.stach@pengutronix.de
Subject: Re: [PATCH v2] mv88e6xxx: Add serdes Rx statistics
Date: Fri, 27 Dec 2019 16:34:27 -0800 (PST) [thread overview]
Message-ID: <20191227.163427.23695455695969544.davem@davemloft.net> (raw)
In-Reply-To: <20191225052238.23334-1-nikita.yoush@cogentembedded.com>
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Date: Wed, 25 Dec 2019 08:22:38 +0300
> If packet checker is enabled in the serdes, then Rx counter registers
> start working, and no side effects have been detected.
>
> This patch enables packet checker automatically when powering serdes on,
> and exposes Rx counter registers via ethtool statistics interface.
>
> Code partially basded by older attempt by Andrew Lunn.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> ---
> Changes from v1:
> - added missing break statement (thanks kbuild test robot <lkp@intel.com>)
> - renamed variable ret -> err to follow the rest of the file
Applied, thanks Nikita.
prev parent reply other threads:[~2019-12-28 0:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 5:22 [PATCH v2] mv88e6xxx: Add serdes Rx statistics Nikita Yushchenko
2019-12-25 20:46 ` Andrew Lunn
2019-12-28 0:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191227.163427.23695455695969544.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).