From: Peter Zijlstra <peterz@infradead.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Will Deacon <will@kernel.org>,
Elena Reshetova <elena.reshetova@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kees Cook <keescook@chromium.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] locking/refcount: add sparse annotations to dec-and-lock functions
Date: Sat, 28 Dec 2019 12:49:18 +0100 [thread overview]
Message-ID: <20191228114918.GU2827@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191226152922.2034-1-ebiggers@kernel.org>
On Thu, Dec 26, 2019 at 09:29:22AM -0600, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Wrap refcount_dec_and_lock() and refcount_dec_and_lock_irqsave() with
> macros using __cond_lock() so that 'sparse' doesn't report warnings
> about unbalanced locking when using them.
>
> This is the same thing that's done for their atomic_t equivalents.
>
> Don't annotate refcount_dec_and_mutex_lock(), because mutexes don't
> currently have sparse annotations.
I so f'ing hate that __cond_lock() crap. Previously I've suggested
fixing sparse instead of making such an atrocious trainwreck of the
code.
next prev parent reply other threads:[~2019-12-28 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 15:29 [PATCH] locking/refcount: add sparse annotations to dec-and-lock functions Eric Biggers
2019-12-28 11:49 ` Peter Zijlstra [this message]
2019-12-28 20:15 ` Eric Biggers
2019-12-30 18:43 ` Kees Cook
2019-12-30 19:15 ` Eric Biggers
2019-12-30 19:32 ` Kees Cook
2019-12-30 23:38 ` Luc Van Oostenryck
2020-01-03 1:35 ` Linus Torvalds
2020-01-03 2:18 ` Luc Van Oostenryck
2020-01-03 12:55 ` Dan Carpenter
2020-01-06 15:41 ` Peter Zijlstra
2020-01-06 17:54 ` Luc Van Oostenryck
2020-01-07 9:29 ` Peter Zijlstra
2020-01-06 15:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191228114918.GU2827@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=anna-maria@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=ebiggers@kernel.org \
--cc=elena.reshetova@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).