From: Al Viro <viro@zeniv.linux.org.uk>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: Chao Yu <yuchao0@huawei.com>,
linux-erofs@lists.ozlabs.org, David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, chao@kernel.org,
Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH RESEND] erofs: convert to use the new mount fs_context api
Date: Sat, 28 Dec 2019 21:21:56 +0000 [thread overview]
Message-ID: <20191228212156.GU4203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20191227035016.GA142350@architecture4>
On Fri, Dec 27, 2019 at 11:50:16AM +0800, Gao Xiang wrote:
> Hi Al,
>
> Greeting, we plan to convert erofs to new mount api for 5.6
>
> and I just notice your branch
> https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/log/?h=untested.fs_parse
>
> do a lot further work on fs context (e.g. "get rid of ->enums",
> "remove fs_parameter_description name field" and switch to
> use XXXfc() instead of XXXf() with prefixed string).
>
> Does it plan for 5.6 as well? If yes, we will update this patch
> based on the latest branch and maybe have chance to go though
> your tree if it can?
FWIW, I would add the following to what you've already mentioned:
> > +static const struct fs_parameter_spec erofs_param_specs[] = {
> > + fsparam_flag("user_xattr", Opt_user_xattr),
> > + fsparam_flag("nouser_xattr", Opt_nouser_xattr),
> > + fsparam_flag("acl", Opt_acl),
> > + fsparam_flag("noacl", Opt_noacl),
better off as
fsparam_flag_no("user_xattr", Opt_user_xattr),
fsparam_flag_no("acl", Opt_acl),
> > + case Opt_user_xattr:
if (result.boolean)
set_opt(sbi, XATTR_USER);
else
clear_opt(sbi, XATTR_USER);
> > + break;
....
> > + default:
return -ENOPARAM;
BTW, what's the point of using invalf() in contexts where
the return value is ignored? Why not simply go for errorf()
(or errorfc(), for that matter)?
I do plan that branch (or an equivalent, as far as filesystems
are concerned - there might be a bit of additional rework in
the beginning + currently missing modifications of docs) for
5.6. So updated patch would be welcome - I can do that myself,
but if you can rebase it on top of that branch it would save
time.
next prev parent reply other threads:[~2019-12-28 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 2:25 [PATCH RESEND] erofs: convert to use the new mount fs_context api Chao Yu
2019-12-27 3:50 ` Gao Xiang
2019-12-28 21:21 ` Al Viro [this message]
2019-12-29 2:44 ` Gao Xiang
2019-12-30 3:47 ` [PATCH v2 rebased] " Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191228212156.GU4203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chao@kernel.org \
--cc=dhowells@redhat.com \
--cc=gaoxiang25@huawei.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).