linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wu Hao <hao.wu@intel.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: yu kuai <yukuai3@huawei.com>,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	yi.zhang@huawe.com, zhengbin13@huawei.com
Subject: Re: [PATCH] fpga: dfl: afu: remove set but not used variable 'afu'
Date: Mon, 30 Dec 2019 09:53:12 +0800	[thread overview]
Message-ID: <20191230015312.GB6839@hao-dev> (raw)
In-Reply-To: <20191227225809.GB1643@archbook>

On Fri, Dec 27, 2019 at 02:58:09PM -0800, Moritz Fischer wrote:
> On Thu, Dec 26, 2019 at 08:15:33PM +0800, yu kuai wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> > 
> > drivers/fpga/dfl-afu-main.c: In function ‘afu_dev_destroy’:
> > drivers/fpga/dfl-afu-main.c:816:18: warning: variable ‘afu’
> > set but not used [-Wunused-but-set-variable]
> > 
> > It is never used, and so can be removed.
> > 
> > Signed-off-by: yu kuai <yukuai3@huawei.com>
> > ---
> >  drivers/fpga/dfl-afu-main.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c
> > index e4a34dc7947f..65437b6a6842 100644
> > --- a/drivers/fpga/dfl-afu-main.c
> > +++ b/drivers/fpga/dfl-afu-main.c
> > @@ -813,10 +813,8 @@ static int afu_dev_init(struct platform_device *pdev)
> >  static int afu_dev_destroy(struct platform_device *pdev)
> >  {
> >  	struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
> > -	struct dfl_afu *afu;
> >  
> >  	mutex_lock(&pdata->lock);
> > -	afu = dfl_fpga_pdata_get_private(pdata);
> >  	afu_mmio_region_destroy(pdata);
> >  	afu_dma_region_destroy(pdata);
> >  	dfl_fpga_pdata_set_private(pdata, NULL);
> > -- 
> > 2.17.2
> > 
> Acked-by: Moritz Fischer <mdf@kernel.org>
> 
> I'll get to the patches in the new year.

Thanks Kuai and Moritz. :)

Acked-by: Wu Hao <hao.wu@intel.com>

Hao
> 
> Thanks,
> Moritz

  reply	other threads:[~2019-12-30  2:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-26 12:15 [PATCH] fpga: dfl: afu: remove set but not used variable 'afu' yu kuai
2019-12-27 22:58 ` Moritz Fischer
2019-12-30  1:53   ` Wu Hao [this message]
2020-01-03  4:48     ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191230015312.GB6839@hao-dev \
    --to=hao.wu@intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=yi.zhang@huawe.com \
    --cc=yukuai3@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).