From: Jonathan Cameron <jic23@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"Angus Ainslie (Purism)" <angus@akkea.ca>,
Marco Felsch <m.felsch@pengutronix.de>,
Allison Randal <allison@lohutok.net>,
Thomas Gleixner <tglx@linutronix.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: light: vcnl4000: Fix scale for vcnl4040
Date: Mon, 30 Dec 2019 16:49:24 +0000 [thread overview]
Message-ID: <20191230164924.42614610@archlinux> (raw)
In-Reply-To: <6adc62445cac7d16e4688aea905dc1c9cc128488.1577442112.git.agx@sigxcpu.org>
On Fri, 27 Dec 2019 11:22:54 +0100
Guido Günther <agx@sigxcpu.org> wrote:
> According to the data sheet the ambient sensor's scale is 0.12 lux/step
> (not 0.024 lux/step as used by vcnl4200) when the integration time is
> 80ms. The integration time is currently hardcoded in the driver to that
> value.
>
> See p. 8 in https://www.vishay.com/docs/84307/designingvcnl4040.pdf
>
> Fixes: 5a441aade5b3 ("light: vcnl4000 add support for the VCNL4040 proximity and light sensor")
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/iio/light/vcnl4000.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
> index 16dacea9eadf..b0e241aaefb4 100644
> --- a/drivers/iio/light/vcnl4000.c
> +++ b/drivers/iio/light/vcnl4000.c
> @@ -163,7 +163,6 @@ static int vcnl4200_init(struct vcnl4000_data *data)
> if (ret < 0)
> return ret;
>
> - data->al_scale = 24000;
> data->vcnl4200_al.reg = VCNL4200_AL_DATA;
> data->vcnl4200_ps.reg = VCNL4200_PS_DATA;
> switch (id) {
> @@ -172,11 +171,13 @@ static int vcnl4200_init(struct vcnl4000_data *data)
> /* show 54ms in total. */
> data->vcnl4200_al.sampling_rate = ktime_set(0, 54000 * 1000);
> data->vcnl4200_ps.sampling_rate = ktime_set(0, 4200 * 1000);
> + data->al_scale = 24000;
> break;
> case VCNL4040_PROD_ID:
> /* Integration time is 80ms, add 10ms. */
> data->vcnl4200_al.sampling_rate = ktime_set(0, 100000 * 1000);
> data->vcnl4200_ps.sampling_rate = ktime_set(0, 100000 * 1000);
> + data->al_scale = 120000;
> break;
> }
> data->vcnl4200_al.last_measurement = ktime_set(0, 0);
prev parent reply other threads:[~2019-12-30 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 10:22 [PATCH v2] iio: light: vcnl4000: Fix scale for vcnl4040 Guido Günther
2019-12-30 16:49 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230164924.42614610@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=agx@sigxcpu.org \
--cc=allison@lohutok.net \
--cc=angus@akkea.ca \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=pmeerw@pmeerw.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).