From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FE5C3F68F for ; Tue, 31 Dec 2019 00:34:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA8B0206CB for ; Tue, 31 Dec 2019 00:34:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FWgzqnoC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727816AbfLaAeE (ORCPT ); Mon, 30 Dec 2019 19:34:04 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:32733 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727773AbfLaAeD (ORCPT ); Mon, 30 Dec 2019 19:34:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577752442; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=qftNDtaZo3ULGRqvQSgu3WPfMkeZPf0iuGFu53nIq9A=; b=FWgzqnoC0+cgC7z17B9NDaUxzoNpYN0IW9CaD77A3BVtprrZmmRs6qNFZ53njh2nTCb7MK /U4xOS8gabOBbuicWe+AYoKMLeoHJ3VUO07I7CTdrSg744BrJxtPO+R/JXSu5etlkTeaNQ /KU4cjRHc4gM/Cgjm6siPDlpUHtQCm4= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-_M0aEYpUP9KxeN31Y9Fmtg-1; Mon, 30 Dec 2019 19:34:00 -0500 X-MC-Unique: _M0aEYpUP9KxeN31Y9Fmtg-1 Received: by mail-pg1-f197.google.com with SMTP id t12so23046413pgs.13 for ; Mon, 30 Dec 2019 16:34:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=qftNDtaZo3ULGRqvQSgu3WPfMkeZPf0iuGFu53nIq9A=; b=aHOXvEAmOKComuB3KMxqriatoLjfr8VXP+HK1FpwYy/Py8Ig2QWJqGMIaPZpz4Bh0t mYtCGjVRbWJqG6nf8koJZIlSKezSCOhsJSRBVFwvHTPptHAmF9hWvOTWTRNKuO0BPGzs ewUxVK0b9LDKeNDM0HD9W2mrr/bjgRP1KjWefQjxIvKhFdF/N6a+Ew5cGLfw2a1Z6UpH oSQgzlXhnHkpvv3C+ux0nY+/aHjPIaqY8hjwYbIZhIekWmorkiBQU//JpVS4MWIWoK8s aP30vK2guU1m1AlyZN6Lp5dtbz/PVpcu0PEVKL71ORQTLizIv7a28zR03H2sISsqQtg7 PBxw== X-Gm-Message-State: APjAAAUI9J4OR8T8jEb+OuNxvJBYAmt2Snqolj1jkGGHM8yy9/EL5GEQ XPKZy1r4znOKDuEi5A3eUkXJN4dql2NvWtPFfdwS2SPAcbORYIwvjOWvd6vfKnjAwaOsRpC1FNu EToAoglS8rA9pfmFTsocQN5DM X-Received: by 2002:a63:cf08:: with SMTP id j8mr73919648pgg.292.1577752439965; Mon, 30 Dec 2019 16:33:59 -0800 (PST) X-Google-Smtp-Source: APXvYqwZwkkMBxFxll1aEN5EY1ibYiENvv7pvVZS4C3JEyBBDfqQzdb6HcWQEGzKVHCoU+cXWgAeDw== X-Received: by 2002:a63:cf08:: with SMTP id j8mr73919621pgg.292.1577752439734; Mon, 30 Dec 2019 16:33:59 -0800 (PST) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id d2sm749409pjv.18.2019.12.30.16.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2019 16:33:58 -0800 (PST) Date: Mon, 30 Dec 2019 17:33:55 -0700 From: Jerry Snitselaar To: Jarkko Sakkinen Cc: Dan Williams , Greg KH , Christian Bundy , Jason Gunthorpe , Peter Huewe , Stefan Berger , stable-commits@vger.kernel.org, linux-integrity@vger.kernel.org, Linux Kernel Mailing List Subject: Re: Patch "tpm_tis: reserve chip for duration of tpm_tis_core_init" has been added to the 5.4-stable tree Message-ID: <20191231003355.l4zhdingdw5h2ntx@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Jarkko Sakkinen , Dan Williams , Greg KH , Christian Bundy , Jason Gunthorpe , Peter Huewe , Stefan Berger , stable-commits@vger.kernel.org, linux-integrity@vger.kernel.org, Linux Kernel Mailing List References: <1577122577157232@kroah.com> <50217a688ffa56cf5f150ffd358daba2a88cad48.camel@linux.intel.com> <20191228151526.GA6971@linux.intel.com> <2c4a80e0d30bf1dfe89c6e3469d1dbfb008275fa.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <2c4a80e0d30bf1dfe89c6e3469d1dbfb008275fa.camel@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue Dec 31 19, Jarkko Sakkinen wrote: >On Sun, 2019-12-29 at 23:41 -0800, Dan Williams wrote: >> This looked like the wrong revert to me, and testing confirms that >> this does not fix the problem. >> >> As I mentioned in the original report [1] the commit that bisect flagged was: >> >> 5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's >> >> That commit moved tpm_chip_start() before irq probing. Commit >> 21df4a8b6018 "tpm_tis: reserve chip for duration of tpm_tis_core_init" >> does not appear to change anything in that regard. >> >> Perhaps this hardware has always had broken interrupts and needs to be >> quirked off? I'm trying an experiment with tpm_tis_core.interrupts=0 >> workaround. >> >> >> [1]: https://lore.kernel.org/linux-integrity/CAA9_cmeLnHK4y+usQaWo72nUG3RNsripuZnS-koY4XTRC+mwJA@mail.gmail.com/ > >I think for short term, yes, it is better to revert the commits >that make things more broken. > >for-linus-v5.5-rc5 branch contains three commits that exactly do >this i.e. the reverts that Stefan sent and revert to Jerry's earlier >commit. > >After that is out of the table it is easier to analyze how the code >should be actually refactored. Like, I have no idea when I get >local HW that can reproduce this and Jerry still seems to have the >same issue. It'd be nice make the exactly right changes instead of >reverts but situation is what it is. > Unfortunately I haven't found a system yet where I get into this code path. So I've been relying on Dan's testing and the owner of the t490s. >Please check the branch and ACK/NAK if I can add tested-by's (and >other tags). > >/Jarkko >