From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DATE_IN_PAST_06_12, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 592AAC32767 for ; Fri, 3 Jan 2020 07:00:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 264B024650 for ; Fri, 3 Jan 2020 07:00:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578034841; bh=7mMl2coCIwrjv8ZjuppYv4Ajb+6am/ysbKBocSDinTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Q5gqQ4t8ofX5jVD6CFLb1WfgLwUgblOhjdG0PXkc334SG2yiXzLweb0dO9QxIxlgF 52qmk6vtdavDVpinZRCnn23E1kUO66LQH2xVCGlUnHXaHBppyfNCChzexqXV9MLioY brXCARPygKAbLRzjNAT48Zq8QZjyZKtvgmnCbgT0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727370AbgACHAk (ORCPT ); Fri, 3 Jan 2020 02:00:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:46916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbgACHAk (ORCPT ); Fri, 3 Jan 2020 02:00:40 -0500 Received: from localhost (unknown [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCB8622B48; Fri, 3 Jan 2020 07:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578034839; bh=7mMl2coCIwrjv8ZjuppYv4Ajb+6am/ysbKBocSDinTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BXRDi3lkGZnwcirnTx3gVDanwDnBUP6yPsrjAB8vlrQz+ggkGodhpaS0O6emR3R71 TzXLxo0CnV3KNUJSN9Ne5vN9R434xWb2TJCu+ZBXbkjABDf1VjJMDQASqX5pWfZds7 UBDTcy+6RAxiIyJ/94vHw6UE/GRTTtCpH/F1QGbg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Benoit Parrot , "Lad, Prabhakar" , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 012/137] media: i2c: ov2659: fix s_stream return value Date: Thu, 2 Jan 2020 23:06:25 +0100 Message-Id: <20200102220548.391275901@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.618583146@linuxfoundation.org> References: <20200102220546.618583146@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Benoit Parrot [ Upstream commit 85c4043f1d403c222d481dfc91846227d66663fb ] In ov2659_s_stream() return value for invoked function should be checked and propagated. Signed-off-by: Benoit Parrot Acked-by: Lad, Prabhakar Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/ov2659.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c index fadec1d70582..4f43e8c43950 100644 --- a/drivers/media/i2c/ov2659.c +++ b/drivers/media/i2c/ov2659.c @@ -1204,11 +1204,15 @@ static int ov2659_s_stream(struct v4l2_subdev *sd, int on) goto unlock; } - ov2659_set_pixel_clock(ov2659); - ov2659_set_frame_size(ov2659); - ov2659_set_format(ov2659); - ov2659_set_streaming(ov2659, 1); - ov2659->streaming = on; + ret = ov2659_set_pixel_clock(ov2659); + if (!ret) + ret = ov2659_set_frame_size(ov2659); + if (!ret) + ret = ov2659_set_format(ov2659); + if (!ret) { + ov2659_set_streaming(ov2659, 1); + ov2659->streaming = on; + } unlock: mutex_unlock(&ov2659->lock); -- 2.20.1