From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C81C3276C for ; Thu, 2 Jan 2020 22:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29F1224653 for ; Thu, 2 Jan 2020 22:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004636; bh=nAcI7t8OhKaTP++QeUcoAQ6fI7SyHY73WwVP837wTKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RqbidJgH359Mdcv1wQEW7c/xHfW0S5Zztm1hM6vGe2OT4FbwWhdABIS/fXrLNxuYn Fq29KS0/46j1aS1jqfanRzU+o5ow0WxkCrEybq4MHPn8Q6ieGbXQ9zr3MFJnrQE7FO 2MyRYGiXeMGGt2HFWdNGoI6L95jipK0tNASe6Do0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730804AbgABWhP (ORCPT ); Thu, 2 Jan 2020 17:37:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:49376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731056AbgABWhL (ORCPT ); Thu, 2 Jan 2020 17:37:11 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C635720866; Thu, 2 Jan 2020 22:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004631; bh=nAcI7t8OhKaTP++QeUcoAQ6fI7SyHY73WwVP837wTKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GQ1IFb0Q4MuNezOjzhXIFmsAV9h9XnoUfKNB9lJo9iWA0CyHrjZTJX8dGJ7fSyUZ4 3HYKhwWd5XdTWSsQJdLYuX2WbadQ3Q/ZVaPO1Zk5UGYJsbcqLE9UvS0nzII6E7YAo+ lfW0mvkGuWNhI8znaQ4PlZDtu5PXVteNgh4Rl+TI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 051/137] media: si470x-i2c: add missed operations in remove Date: Thu, 2 Jan 2020 23:07:04 +0100 Message-Id: <20200102220553.434186982@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.618583146@linuxfoundation.org> References: <20200102220546.618583146@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit 2df200ab234a86836a8879a05a8007d6b884eb14 ] The driver misses calling v4l2_ctrl_handler_free and v4l2_device_unregister in remove like what is done in probe failure. Add the calls to fix it. Signed-off-by: Chuhong Yuan Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/radio/si470x/radio-si470x-i2c.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c index 9326439bc49c..f9e1768b8d31 100644 --- a/drivers/media/radio/si470x/radio-si470x-i2c.c +++ b/drivers/media/radio/si470x/radio-si470x-i2c.c @@ -460,6 +460,8 @@ static int si470x_i2c_remove(struct i2c_client *client) video_unregister_device(&radio->videodev); kfree(radio); + v4l2_ctrl_handler_free(&radio->hdl); + v4l2_device_unregister(&radio->v4l2_dev); return 0; } -- 2.20.1