From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D08FC3276C for ; Thu, 2 Jan 2020 22:38:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51F85222C3 for ; Thu, 2 Jan 2020 22:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004684; bh=0iw2TG1uCRrbexMNAybi83l3MiKexq2/ZLsmFb6Tu2A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=e6/bHwrPbN7o2hVLlgyXV1WZePB2/ZaT323tmJv7941yqkXPvYFpnmdNtqQD00hJ4 YsGzL+oKMr3d7t9izKORl4RF+aBtSwPnlwWQXxJvY+WdiQ47Xeoa8IniQz+B+jTS19 KBeSyPmyDFwuCHkuh0RU1TmaCzUY23qos6im/cMw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731190AbgABWiD (ORCPT ); Thu, 2 Jan 2020 17:38:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:51292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727898AbgABWh7 (ORCPT ); Thu, 2 Jan 2020 17:37:59 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D592C21835; Thu, 2 Jan 2020 22:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004679; bh=0iw2TG1uCRrbexMNAybi83l3MiKexq2/ZLsmFb6Tu2A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LN4Wcg8x2ScH/T0IPISLGo9dSnWl3/UwvNhQ0ObKgPPxhplX9t6vTgkL+ki/vgVU4 36r9w09hbuWbcPQ6lFosD+Wsqr+AjzLhfJaa+wfpDeXnN32IEiEAXBRGp3JPC64S4+ 1koz/1CZBsq5IYoTI6r/SkxNcpzzdmit3/4xf2Hg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Barry Song , Stephan Gerhold , Daniel Thompson , Mark Brown , Lee Jones , Sasha Levin Subject: [PATCH 4.4 107/137] mfd: mfd-core: Honour Device Trees request to disable a child-device Date: Thu, 2 Jan 2020 23:08:00 +0100 Message-Id: <20200102220601.538157580@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.618583146@linuxfoundation.org> References: <20200102220546.618583146@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lee Jones [ Upstream commit 6b5c350648b857047b47acf74a57087ad27d6183 ] Until now, MFD has assumed all child devices passed to it (via mfd_cells) are to be registered. It does not take into account requests from Device Tree and the like to disable child devices on a per-platform basis. Well now it does. Link: https://www.spinics.net/lists/arm-kernel/msg366309.html Link: https://lkml.org/lkml/2019/8/22/1350 Reported-by: Barry Song Reported-by: Stephan Gerhold Reviewed-by: Daniel Thompson Reviewed-by: Mark Brown Tested-by: Stephan Gerhold Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/mfd-core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index 215bb5eeb5ac..85f4e5582371 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -177,6 +177,11 @@ static int mfd_add_device(struct device *parent, int id, if (parent->of_node && cell->of_compatible) { for_each_child_of_node(parent->of_node, np) { if (of_device_is_compatible(np, cell->of_compatible)) { + if (!of_device_is_available(np)) { + /* Ignore disabled devices error free */ + ret = 0; + goto fail_alias; + } pdev->dev.of_node = np; pdev->dev.fwnode = &np->fwnode; break; -- 2.20.1