From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5832C3276C for ; Thu, 2 Jan 2020 22:33:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81A4620866 for ; Thu, 2 Jan 2020 22:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004423; bh=VJZ/oYc6ReQtUDu6H24cPfLjQVk3H/I46//pOOe/Uw8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=v4M54WMVdbTgTcatYvx9R71klEqpTvWgJqrZfgS3jqyr046YA2KwG5Ha4BUSeKDgU 9i6gzclPQS1G7JUYI9wJLTqNKt3P6if0qOkLOV/qEZsNup6yNCUAHTjXyMsNlRQTAZ phexdI81Rpyuwg2pbG0TM1LwmNBj5ckVaR/ZdfJo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730575AbgABWdm (ORCPT ); Thu, 2 Jan 2020 17:33:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:41312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730430AbgABWdj (ORCPT ); Thu, 2 Jan 2020 17:33:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 821F220863; Thu, 2 Jan 2020 22:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004419; bh=VJZ/oYc6ReQtUDu6H24cPfLjQVk3H/I46//pOOe/Uw8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EiPJSqb5B0Ae0y/7EtdsB3m+tLqAx1phNUm+PZKZ7MIWy+xlmJRsn/0Xr8mGWciIg QIExnL/LuSMJMWmsYi47SBbH1hNGlNdBu2vtf0SSDWIvaJTNiMkH3Wv72c5zSy9RH/ soIePACl1eRr4SBGPYWAPQAhbSQLU515vTymfjFk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Taehee Yoo , Jakub Kicinski Subject: [PATCH 4.9 171/171] gtp: avoid zero size hashtable Date: Thu, 2 Jan 2020 23:08:22 +0100 Message-Id: <20200102220610.316545567@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.960200039@linuxfoundation.org> References: <20200102220546.960200039@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Taehee Yoo [ Upstream commit 6a902c0f31993ab02e1b6ea7085002b9c9083b6a ] GTP default hashtable size is 1024 and userspace could set specific hashtable size with IFLA_GTP_PDP_HASHSIZE. If hashtable size is set to 0 from userspace, hashtable will not work and panic will occur. Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)") Signed-off-by: Taehee Yoo Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/gtp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -677,10 +677,13 @@ static int gtp_newlink(struct net *src_n if (err < 0) goto out_err; - if (!data[IFLA_GTP_PDP_HASHSIZE]) + if (!data[IFLA_GTP_PDP_HASHSIZE]) { hashsize = 1024; - else + } else { hashsize = nla_get_u32(data[IFLA_GTP_PDP_HASHSIZE]); + if (!hashsize) + hashsize = 1024; + } err = gtp_hashtable_new(gtp, hashsize); if (err < 0)