From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com,
willy@infradead.org
Subject: Re: [Patch v2] mm/rmap.c: split huge pmd when it really is
Date: Fri, 3 Jan 2020 16:26:50 +0300 [thread overview]
Message-ID: <20200103132650.jlyd37k6fcvycmy7@box> (raw)
In-Reply-To: <20200103130554.GA20078@richard>
On Fri, Jan 03, 2020 at 09:05:54PM +0800, Wei Yang wrote:
> On Fri, Jan 03, 2020 at 03:18:46PM +0800, Wei Yang wrote:
> >On Tue, Dec 24, 2019 at 06:28:56AM +0800, Wei Yang wrote:
> >>When page is not NULL, function is called by try_to_unmap_one() with
> >>TTU_SPLIT_HUGE_PMD set. There are two cases to call try_to_unmap_one()
> >>with TTU_SPLIT_HUGE_PMD set:
> >>
> >> * unmap_page()
> >> * shrink_page_list()
> >>
> >>In both case, the page passed to try_to_unmap_one() is PageHead() of the
> >>THP. If this page's mapping address in process is not HPAGE_PMD_SIZE
> >>aligned, this means the THP is not mapped as PMD THP in this process.
> >>This could happen when we do mremap() a PMD size range to an un-aligned
> >>address.
> >>
> >>Currently, this case is handled by following check in __split_huge_pmd()
> >>luckily.
> >>
> >> page != pmd_page(*pmd)
> >>
> >>This patch checks the address to skip some work.
> >
> >I am sorry to forget address Kirill's comment in 1st version.
> >
> >The first one is the performance difference after this change for a PTE
> >mappged THP.
> >
> >Here is the result:(in cycle)
> >
> > Before Patched
> >
> > 963 195
> > 988 40
> > 895 78
> >
> >Average 948 104
> >
> >So the change reduced 90% time for function split_huge_pmd_address().
Right.
But do we have a scenario, where the performance of
split_huge_pmd_address() matters? I mean, it it called as part of rmap
walk, attempt to split huge PMD where we don't have huge PMD should be
within noise.
> >For the 2nd comment, the vma check. Let me take a further look to analysis.
> >
> >Thanks for Kirill's suggestion.
> >
>
> For 2nd comment, check vma could hold huge page.
>
> You mean do this check ?
>
> vma->vm_start <= address && vma->vm_end >= address + HPAGE_PMD_SIZE
>
> This happens after munmap a partial of the THP range? After doing so, we can
> skip split_pmd for this case.
Okay, you are right. This kind of check would not be safe as we
split_huge_pmd_address() after adjusting VMA with expectation of splitting
PMD on boundary of the VMA.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2020-01-03 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 22:28 [Patch v2] mm/rmap.c: split huge pmd when it really is Wei Yang
2019-12-23 23:11 ` Matthew Wilcox
2019-12-24 1:56 ` Wei Yang
2019-12-27 15:13 ` Matthew Wilcox
2019-12-29 22:07 ` Wei Yang
2020-01-03 7:18 ` Wei Yang
2020-01-03 13:05 ` Wei Yang
2020-01-03 13:26 ` Kirill A. Shutemov [this message]
2020-01-03 14:01 ` Wei Yang
2020-01-07 12:03 ` Kirill A. Shutemov
2020-01-08 0:36 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103132650.jlyd37k6fcvycmy7@box \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).