From: Rob Herring <robh@kernel.org>
To: Dikshita Agarwal <dikshita@codeaurora.org>
Cc: linux-media@vger.kernel.org, stanimir.varbanov@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, vgarodia@codeaurora.org
Subject: Re: [PATCH V3 2/4] dt-bindings: media: venus: Add sc7180 DT schema
Date: Fri, 3 Jan 2020 17:43:57 -0700 [thread overview]
Message-ID: <20200104004357.GA16614@bogus> (raw)
In-Reply-To: <1577971501-3732-3-git-send-email-dikshita@codeaurora.org>
On Thu, Jan 02, 2020 at 06:54:59PM +0530, Dikshita Agarwal wrote:
> Add new qcom,sc7180-venus DT binding schema.
>
> Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>
> ---
> .../bindings/media/qcom,venus-sc7180.yaml | 136 +++++++++++++++++++++
> 1 file changed, 136 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/qcom,venus-sc7180.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,venus-sc7180.yaml b/Documentation/devicetree/bindings/media/qcom,venus-sc7180.yaml
> new file mode 100644
> index 0000000..b78952c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,venus-sc7180.yaml
> @@ -0,0 +1,136 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/media/qcom,venus-sc7180.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm Venus video encode and decode accelerators
> +
> +maintainers:
> + - Stanimir Varbanov <stanimir.varbanov@linaro.org>
> +
> +description: |
> + The Venus IP is a video encode and decode accelerator present
> + on Qualcomm platforms
> +
> +properties:
> + compatible:
> + const: "qcom,sc7180-venus"
No need for quotes.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 2
> +
> + power-domain-names:
> + maxItems: 2
You can drop maxItems. Implied by size of 'items'.
> + items:
> + - const: venus
> + - const: vcodec0
> +
> + clocks:
> + maxItems: 5
> +
> + clock-names:
> + items:
> + - const: core
> + - const: iface
> + - const: bus
> + - const: vcodec0_core
> + - const: vcodec0_bus
> +
> + iommus:
> + minItems: 1
> + maxItems: 20
As I said on the other Venus schemas, can you really have 20 IOMMUs
attached? This is a single SoC, you should know how many are attached.
Rob
> +
> + memory-region:
> + maxItems: 1
> +
> + video-core0:
> + type: object
> +
> + properties:
> + compatible:
> + const: "venus-decoder"
> +
> + required:
> + - compatible
> +
> + additionalProperties: false
> +
> + video-core1:
> + type: object
> +
> + properties:
> + compatible:
> + const: "venus-encoder"
> +
> + required:
> + - compatible
> +
> + additionalProperties: false
> +
> + video-firmware:
> + type: object
> +
> + description: |
> + Firmware subnode is needed when the platform does not
> + have TrustZone.
> +
> + properties:
> + iommus:
> + minItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - power-domains
> + - power-domain-names
> + - clocks
> + - clock-names
> + - iommus
> + - memory-region
> + - video-core0
> + - video-core1
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/qcom,videocc-sc7180.h>
> +
> + venus: video-codec@aa00000 {
> + compatible = "qcom,sc7180-venus";
> + reg = <0 0x0aa00000 0 0xff000>;
> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&videocc VENUS_GDSC>,
> + <&videocc VCODEC0_GDSC>;
> + power-domain-names = "venus", "vcodec0";
> + clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
> + <&videocc VIDEO_CC_VENUS_AHB_CLK>,
> + <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>,
> + <&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
> + <&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
> + clock-names = "core", "iface", "bus",
> + "vcodec0_core", "vcodec0_bus";
> + iommus = <&apps_smmu 0x0c00 0x60>;
> + memory-region = <&venus_mem>;
> +
> + interconnects = <&mmss_noc MASTER_VIDEO_P0 &mc_virt SLAVE_EBI1>,
> + <&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_VENUS_CFG>;
> + interconnect-names = "video-mem", "cpu-cfg";
Not documented.
> +
> + video-core0 {
> + compatible = "venus-decoder";
> + };
> +
> + video-core1 {
> + compatible = "venus-encoder";
> + };
> +
> + };
> --
> 1.9.1
>
next prev parent reply other threads:[~2020-01-04 0:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 13:24 [PATCH V3 0/4] Enable video on sc7180 Dikshita Agarwal
2020-01-02 13:24 ` [PATCH V3 1/4] arm64: dts: sc7180: Add Venus video codec DT node Dikshita Agarwal
2020-01-07 13:52 ` Stanimir Varbanov
2020-01-02 13:24 ` [PATCH V3 2/4] dt-bindings: media: venus: Add sc7180 DT schema Dikshita Agarwal
2020-01-04 0:43 ` Rob Herring [this message]
2020-01-07 13:56 ` Stanimir Varbanov
2020-01-02 13:25 ` [PATCH V3 3/4] venus: core: add sc7180 DT compatible and resource struct Dikshita Agarwal
2020-01-07 14:02 ` Stanimir Varbanov
2020-01-02 13:25 ` [PATCH V3 4/4] arm64: dts: sc7180: Add Venus firmware subnode Dikshita Agarwal
2020-01-07 14:01 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200104004357.GA16614@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).