From: Herbert Xu <herbert@gondor.apana.org.au>
To: Rijo Thomas <Rijo-john.Thomas@amd.com>
Cc: "David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
tee-dev@lists.linaro.org, Nimesh Easow <Nimesh.Easow@amd.com>,
Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
Jens Wiklander <jens.wiklander@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Gary Hook <gary.hook@amd.com>
Subject: Re: [PATCH 0/4] TEE driver for AMD APUs
Date: Sat, 4 Jan 2020 13:50:27 +0800 [thread overview]
Message-ID: <20200104055027.2zlf32e5yhsdqgm2@gondor.apana.org.au> (raw)
In-Reply-To: <cover.1577423898.git.Rijo-john.Thomas@amd.com>
On Fri, Dec 27, 2019 at 10:53:59AM +0530, Rijo Thomas wrote:
> This patch series introduces Trusted Execution Environment (TEE) driver
> for AMD APU enabled systems. The TEE is a secure area of a processor which
> ensures that sensitive data is stored, processed and protected in an
> isolated and trusted environment. The AMD Secure Processor is a dedicated
> processor which provides TEE to enable HW platform security. It offers
> protection against software attacks generated in Rich Operating
> System (Rich OS) such as Linux running on x86. The AMD-TEE Trusted OS
> running on AMD Secure Processor allows loading and execution of security
> sensitive applications called Trusted Applications (TAs). An example of
> a TA would be a DRM (Digital Rights Management) TA written to enforce
> content protection.
>
> Linux already provides a tee subsystem, which is described in [1]. The tee
> subsystem provides a generic TEE ioctl interface which can be used by user
> space to talk to a TEE driver. AMD-TEE driver registers with tee subsystem
> and implements tee function callbacks in an AMD platform specific manner.
>
> The following TEE commands are recognized by AMD-TEE Trusted OS:
> 1. TEE_CMD_ID_LOAD_TA : Load Trusted Application (TA) binary into TEE
> environment
> 2. TEE_CMD_ID_UNLOAD_TA : Unload TA binary from TEE environment
> 3. TEE_CMD_ID_OPEN_SESSION : Open session with loaded TA
> 4. TEE_CMD_ID_CLOSE_SESSION : Close session with loaded TA
> 5. TEE_CMD_ID_INVOKE_CMD : Invoke a command with loaded TA
> 6. TEE_CMD_ID_MAP_SHARED_MEM : Map shared memory
> 7. TEE_CMD_ID_UNMAP_SHARED_MEM : Unmap shared memory
>
> Each command has its own payload format. The AMD-TEE driver creates a
> command buffer payload for submission to AMD-TEE Trusted OS. The driver
> uses the services of AMD Secure Processor driver to submit commands
> to the Trusted OS. Further details can be found in [1].
>
> This patch series is based on cryptodev-2.6 tree with base commit
> c6d633a92749 (crypto: algapi - make unregistration functions return void).
>
> [1] https://www.kernel.org/doc/Documentation/tee.txt
>
> Rijo Thomas (4):
> tee: allow compilation of tee subsystem for AMD CPUs
> tee: add AMD-TEE driver
> tee: amdtee: check TEE status during driver initialization
> Documentation: tee: add AMD-TEE driver details
>
> Documentation/tee.txt | 81 ++++++
> drivers/crypto/ccp/tee-dev.c | 11 +
> drivers/tee/Kconfig | 4 +-
> drivers/tee/Makefile | 1 +
> drivers/tee/amdtee/Kconfig | 8 +
> drivers/tee/amdtee/Makefile | 5 +
> drivers/tee/amdtee/amdtee_if.h | 183 +++++++++++++
> drivers/tee/amdtee/amdtee_private.h | 159 +++++++++++
> drivers/tee/amdtee/call.c | 373 ++++++++++++++++++++++++++
> drivers/tee/amdtee/core.c | 516 ++++++++++++++++++++++++++++++++++++
> drivers/tee/amdtee/shm_pool.c | 93 +++++++
> include/linux/psp-tee.h | 18 ++
> include/uapi/linux/tee.h | 1 +
> 13 files changed, 1451 insertions(+), 2 deletions(-)
> create mode 100644 drivers/tee/amdtee/Kconfig
> create mode 100644 drivers/tee/amdtee/Makefile
> create mode 100644 drivers/tee/amdtee/amdtee_if.h
> create mode 100644 drivers/tee/amdtee/amdtee_private.h
> create mode 100644 drivers/tee/amdtee/call.c
> create mode 100644 drivers/tee/amdtee/core.c
> create mode 100644 drivers/tee/amdtee/shm_pool.c
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-01-04 5:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 5:23 [PATCH 0/4] TEE driver for AMD APUs Rijo Thomas
2019-12-27 5:24 ` [PATCH 1/4] tee: allow compilation of tee subsystem for AMD CPUs Rijo Thomas
2019-12-27 18:37 ` Gary R Hook
2019-12-27 5:24 ` [PATCH 2/4] tee: add AMD-TEE driver Rijo Thomas
2019-12-27 18:37 ` Gary R Hook
2019-12-27 5:24 ` [PATCH 3/4] tee: amdtee: check TEE status during driver initialization Rijo Thomas
2019-12-27 18:37 ` Gary R Hook
2019-12-27 5:24 ` [PATCH 4/4] Documentation: tee: add AMD-TEE driver details Rijo Thomas
2019-12-27 18:38 ` Gary R Hook
2020-01-04 5:50 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200104055027.2zlf32e5yhsdqgm2@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Devaraj.Rangasamy@amd.com \
--cc=Nimesh.Easow@amd.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=gary.hook@amd.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tee-dev@lists.linaro.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).