From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 650DDC32770 for ; Sat, 4 Jan 2020 09:06:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 393052465B for ; Sat, 4 Jan 2020 09:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578128771; bh=MHDULSZzfbYAw761SebMDzHsX+7nHNjvGFgET6+nwGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BwG/as5PasI9trjKqYNI21USqpnZh9qeecMKS+c2zW14ISRoDA0JJHhNsJznFyYek cIZQ8Ngo2DpNEbsLpprO2JSsrg8kYrXqILiTytVTcNY96kcABp1zt6EQE/wcQAd1Q/ +jSXOPZ5HbXtkxuKrQEYW2ZwWpFcfFkq+WmNaOng= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726290AbgADJGK (ORCPT ); Sat, 4 Jan 2020 04:06:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:60496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726103AbgADJGK (ORCPT ); Sat, 4 Jan 2020 04:06:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9876D2464E; Sat, 4 Jan 2020 09:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578128769; bh=MHDULSZzfbYAw761SebMDzHsX+7nHNjvGFgET6+nwGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R6bJdEMmHaIUoKdghC/bYEEgRfD85nyPldA7HwhFLXraqYVd1QQ9XLJ4QsuRgzQtk RnEKxtx8UeXxfx8IjsBCMK9HdIVGemqSb57rvh3nHV8LWI+IGayTSmM8jkMTqGYIfm r3OLYM4+IvS2cspA6+yWsNuRwTl/zVhmXe/nYWf8= Date: Sat, 4 Jan 2020 10:06:06 +0100 From: Greg Kroah-Hartman To: Mike Kravetz Cc: Arnd Bergmann , Naresh Kamboju , open list , Linus Torvalds , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, Ben Hutchings , lkft-triage@lists.linaro.org, linux- stable , Chengguang Xu , David Howells , Al Viro , Sasha Levin , LTP List , Jan Stancek , John Stultz Subject: Re: [PATCH 5.4 000/191] 5.4.8-stable review Message-ID: <20200104090606.GA1249964@kroah.com> References: <20200102215829.911231638@linuxfoundation.org> <20200103154518.GB1064304@kroah.com> <8283b231-f6e8-876f-7094-d3265096ab9a@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8283b231-f6e8-876f-7094-d3265096ab9a@oracle.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 03, 2020 at 09:56:52AM -0800, Mike Kravetz wrote: > On 1/3/20 9:33 AM, Mike Kravetz wrote: > > On 1/3/20 7:56 AM, Arnd Bergmann wrote: > >> On Fri, Jan 3, 2020 at 4:45 PM Greg Kroah-Hartman > >> wrote: > >>> On Fri, Jan 03, 2020 at 04:29:56PM +0100, Arnd Bergmann wrote: > >>>> On Fri, Jan 3, 2020 at 4:25 PM Arnd Bergmann wrote: > >>>>> > >>>>> On Fri, Jan 3, 2020 at 4:03 PM Naresh Kamboju wrote: > >>>>>> > >>>>>> On Fri, 3 Jan 2020 at 03:42, Greg Kroah-Hartman > >>>>>> wrote: > >>>>> > >>>>> -ENOENT is what you get when hugetlbfs is not mounted, so this hints to > >>>>> > >>>>> 8fc312b32b2 mm/hugetlbfs: fix error handling when setting up mounts > >>>>> > >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.4.y&id=3f549fb42a39bea3b29c0fc12afee53c4a01bec9 > >>>> > >>>> I see that Mike Kravetz suggested not putting this patch into stable in > >>>> > >>>> https://lore.kernel.org/lkml/befca227-cb8a-8f47-617d-e3bf9972bfec@oracle.com/ > >>>> > >>>> but it was picked through the autosel mechanism later. > >>> > >>> So does that mean that Linus's tree shows this LTP failure as well? > >> > >> Yes, according to > >> https://qa-reports.linaro.org/lkft/linux-mainline-oe/tests/ltp-syscalls-tests/memfd_create04 > >> mainline has the same testcase failure, it started happening between > >> v5.4-10135-gc3bfc5dd73c6 and v5.4-10271-g596cf45cbf6e, when the patch > >> was originally merged into 5.5-rc1. > >> > >>> This does seem to fix a real issue, as shown by the LTP test noticing > >>> it, so should the error code value be fixed in Linus's tree? > >> > >> No idea what to conclude from the testcase failure, let's see if Mike has > >> any suggestions. > >> > > > > Thanks for isolating to this patch! > > > > There are dependencies between arch specific code and arch independent code > > during the setup of hugetlb sizes/mounts. Let me take a closer look at the > > arm64 code and get access to a system for debug. > > Before I started investigating, Jan Stancek found and fixed the issue. > > http://lkml.kernel.org/r/a14b944b6e5e207d2f84f43227c98ed1f68290a2.1578072927.git.jstancek@redhat.com Great, thanks for this, now queued up. greg k-h