From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7711CC33C8C for ; Sun, 5 Jan 2020 22:24:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4046820848 for ; Sun, 5 Jan 2020 22:24:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727160AbgAEWYV (ORCPT ); Sun, 5 Jan 2020 17:24:21 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:40594 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbgAEWYV (ORCPT ); Sun, 5 Jan 2020 17:24:21 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D46841573FC02; Sun, 5 Jan 2020 14:24:19 -0800 (PST) Date: Sun, 05 Jan 2020 14:24:19 -0800 (PST) Message-Id: <20200105.142419.337045213193368192.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, paweldembicki@gmail.com, linus.walleij@linaro.org, andrew@lunn.ch, vivien.didelot@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dsa: vsc73xx: Remove dependency on CONFIG_OF From: David Miller In-Reply-To: <20200102233445.12764-1-f.fainelli@gmail.com> References: <20200102233445.12764-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 05 Jan 2020 14:24:20 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Thu, 2 Jan 2020 15:34:45 -0800 > There is no build time dependency on CONFIG_OF, but we do need to make > sure we gate the initialization of the gpio_chip::of_node member with a > proper check on CONFIG_OF_GPIO. This enables the driver to build on > platforms that do not have CONFIG_OF enabled. > > Signed-off-by: Florian Fainelli Applied, thanks. Maybe if this becomes common enough we can have a helper like the ones we have for network namespaces, something like of_node_set().