From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, alobakin@dlink.ru,
rmk+kernel@armlinux.org.uk, andrew@lunn.ch,
vivien.didelot@gmail.com, hauke@hauke-m.de,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
sean.wang@mediatek.com, matthias.bgg@gmail.com,
vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, sdf@google.com,
daniel@iogearbox.net, songliubraving@fb.com, ppenkov@google.com,
mcroce@redhat.com, jakub@cloudflare.com, edumazet@google.com,
paulb@mellanox.com, komachi.yoshiki@gmail.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next] net: dsa: Remove indirect function call for flow dissection
Date: Sun, 05 Jan 2020 14:25:31 -0800 (PST) [thread overview]
Message-ID: <20200105.142531.1912385676087452153.davem@davemloft.net> (raw)
In-Reply-To: <20200102233657.12933-1-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 2 Jan 2020 15:36:53 -0800
> We only need "static" information to be given for DSA flow dissection,
> so replace the expensive call to .flow_dissect() with an integer giving
> us the offset into the packet array of bytes that we must de-reference
> to obtain the protocol number. The overhead was alreayd available from
> the dsa_device_ops structure so use that directly.
>
> The presence of a flow_dissect callback used to indicate that the DSA
> tagger supported returning that information,we now encode this with a
> proto_off value of DSA_PROTO_OFF_UNPSEC if the tagger does not support
> providing that information yet.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes since RFC:
>
> - use a constant instead of the "magic" -1
> - update all tag drivers and build test correctly
At the very least the typos need to be fixed, so marking this changes
requested in patchwork just FYI...
prev parent reply other threads:[~2020-01-05 22:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 23:36 [PATCH net-next] net: dsa: Remove indirect function call for flow dissection Florian Fainelli
2020-01-03 0:19 ` Vladimir Oltean
2020-01-03 20:50 ` Florian Fainelli
2020-01-03 21:28 ` Vladimir Oltean
2020-01-08 18:03 ` Florian Fainelli
2020-01-05 22:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200105.142531.1912385676087452153.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=alobakin@dlink.ru \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=jakub@cloudflare.com \
--cc=komachi.yoshiki@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulb@mellanox.com \
--cc=ppenkov@google.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sdf@google.com \
--cc=sean.wang@mediatek.com \
--cc=songliubraving@fb.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).