From: "Guido Günther" <agx@sigxcpu.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the leds tree
Date: Mon, 6 Jan 2020 16:52:11 +0100 [thread overview]
Message-ID: <20200106155211.GA30225@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <20200106103233.GA32426@amd>
Hi,
On Mon, Jan 06, 2020 at 11:32:33AM +0100, Pavel Machek wrote:
> Hi!
>
> > > After merging the leds tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > drivers/leds/leds-lm3692x.c: In function 'lm3692x_max_brightness':
> > > drivers/leds/leds-lm3692x.c:355:9: error: 'struct lm3692x_led' has no member named 'brightness_ctrl'
> > > 355 | if (led->brightness_ctrl & LM3692X_MAP_MODE_EXP) {
> > > | ^~
> >
> > That's a result of a patch from the mid of the series not being applied.
> > 'leds: lm3692x: Allow to configure brigthness mode' introduces that
> > struct member.
> >
> > > drivers/leds/leds-lm3692x.c: In function 'lm3692x_probe_dt':
> > > drivers/leds/leds-lm3692x.c:437:61: error: 'max_cur' undeclared (first use in this function)
> > > 437 | ret = fwnode_property_read_u32(child, "led-max-microamp", &max_cur);
> > > | ^~~~~~~
> >
> > That somehow got lost during merge of this commit:
> >
> > https://lore.kernel.org/linux-leds/5826b77d42521595e93d01d53475a8881cad1875.1578134779.git.agx@sigxcpu.org/T/#u
> >
> > Pavel, shall i send a patch to fix that up or should we rather try to
> > get the rest of the series in in the right order? Resetting linux-next
> > back to cffd61a5c7755546154539dcd7f36590e91e002f for the moment?
>
> I kept just three patches from the series, and pushed the result.
>
> Could I get the rest of the series, minus the "exponential" stuff, on
> top of that?
>
> Sorry for the confusion,
No problem, reshuffling stuff turned out to be simpler than expected:
https://lore.kernel.org/linux-leds/cover.1578324703.git.agx@sigxcpu.org/T/#mbbbaabea8ebaba1f864d8a4211d9bcac780261aa
If you don't want the exponential mode setting just omit 5/6 and
6/6.
Cheers,
-- Guido
>
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2020-01-06 15:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 3:21 linux-next: build failure after merge of the leds tree Stephen Rothwell
2020-01-06 9:31 ` Guido Günther
2020-01-06 10:32 ` Pavel Machek
2020-01-06 15:52 ` Guido Günther [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-26 20:53 broonie
2022-09-26 21:18 ` Pavel Machek
2022-09-23 4:31 Stephen Rothwell
2019-07-25 2:31 Stephen Rothwell
2019-07-25 18:44 ` Jacek Anaszewski
2013-06-17 5:29 Stephen Rothwell
2013-06-17 6:26 ` Alexander Shiyan
2013-06-21 0:16 ` Stephen Rothwell
2013-06-21 0:27 ` Grant Likely
2013-01-23 4:12 Stephen Rothwell
2013-01-23 6:05 ` Kim, Milo
2012-06-13 4:10 Stephen Rothwell
2012-06-13 4:25 ` Bryan Wu
2012-06-08 2:44 Stephen Rothwell
2012-06-08 3:33 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106155211.GA30225@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).