From: Johan Hovold <johan@kernel.org>
To: Brant Merryman <Brant.Merryman@silabs.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Richard Hendricks <Richard.Hendricks@silabs.com>
Subject: Re: [PATCH] USB: serial: cp210x: Enables usb generic functions for throttle/unthrottle to prevent USB data loss.
Date: Tue, 7 Jan 2020 11:32:07 +0100 [thread overview]
Message-ID: <20200107103207.GC30908@localhost> (raw)
In-Reply-To: <D6486D05-4E0F-4CDF-B178-C386A9075032@silabs.com>
On Wed, Dec 18, 2019 at 06:55:04PM +0000, Brant Merryman wrote:
> USB: serial: cp210x: Enables usb generic functions for
> throttle/unthrottle to prevent USB data loss.
Please resubmit this with a short summary (Subject, < 80 chars) and
separate commit message (body). Try to explain why this is needed a bit
more verbosely.
> Signed-off-by: Brant Merryman <brant.merryman@silabs.com>
> ---
Also always include a changelog here (after "---") when you update
patches, and indicate the patch revision in the Subject prefix (e.g.
this should have been "[PATCH v2]".
Since the two patches you sent are related, you should submit them in a
series. Take a look at git-format-patch and git-send-email for one way
of doing that, more details can be found in:
Documentation/process/submitting-patches.rst
Let's get you up to speed on the process now, so that we don't have to
deal with that bit for your future contributions.
Johan
prev parent reply other threads:[~2020-01-07 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 18:55 [PATCH] USB: serial: cp210x: Enables usb generic functions for throttle/unthrottle to prevent USB data loss Brant Merryman
2020-01-07 10:32 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107103207.GC30908@localhost \
--to=johan@kernel.org \
--cc=Brant.Merryman@silabs.com \
--cc=Richard.Hendricks@silabs.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).