From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
Jesper Nilsson <jespern@axis.com>, Lars Persson <larper@axis.com>,
linux-arm-kernel <linux-arm-kernel@axis.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: artpec6: fix __iomem on reg in set
Date: Tue, 7 Jan 2020 12:18:36 +0100 [thread overview]
Message-ID: <20200107111836.uzvja6m4nb5hh56j@axis.com> (raw)
In-Reply-To: <CACRpkdYFzHCMLj5oU5JMCkQkMZyOvM5351tpO6iEsE8e5nBZWQ@mail.gmail.com>
On Tue, Jan 07, 2020 at 10:39:34AM +0100, Linus Walleij wrote:
> On Wed, Dec 18, 2019 at 6:32 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> > On 18/12/2019 16:26, Jesper Nilsson wrote:
> > > On Wed, Dec 18, 2019 at 11:16:02AM +0100, Ben Dooks (Codethink) wrote:
>
> > >> - unsigned int *reg;
> > >> + unsigned int __iomem *reg;
> > >
> > > void __iomem *reg;
> > >
> > > We're using as an argument to readl()?
> >
> > yes, readl() shoud take an __iomem attributed pointer.
>
> Shall I change it to void as well when applying?
Please do, sorry that my comment wasn't clear above.
> Yours,
> Linus Walleij
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2020-01-07 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 10:16 [PATCH] pinctrl: artpec6: fix __iomem on reg in set Ben Dooks (Codethink)
2019-12-18 16:26 ` Jesper Nilsson
2019-12-18 17:32 ` Ben Dooks
2020-01-07 9:39 ` Linus Walleij
2020-01-07 11:18 ` Jesper Nilsson [this message]
2020-01-07 12:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107111836.uzvja6m4nb5hh56j@axis.com \
--to=jesper.nilsson@axis.com \
--cc=ben.dooks@codethink.co.uk \
--cc=jespern@axis.com \
--cc=larper@axis.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).