From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] opp: quiet down WARN when no valid OPPs remain
Date: Tue, 7 Jan 2020 17:00:55 +0530 [thread overview]
Message-ID: <20200107113055.d4ebweisve73yf3m@vireshk-i7> (raw)
In-Reply-To: <20200107095834.GB3515@qmqm.qmqm.pl>
On 07-01-20, 10:58, Michał Mirosław wrote:
> On Tue, Jan 07, 2020 at 12:11:29PM +0530, Viresh Kumar wrote:
> > On 03-01-20, 20:36, Michał Mirosław wrote:
> > > Per CPU screenful of backtraces is not really that useful. Replace
> > > WARN with a diagnostic discriminating common causes of empty OPP table.
> > But why should a platform have an OPP table in DT where none of them works for
> > it ? I added the warn intentionally here just for that case.
>
> Hmm. I guess we can make it WARN_ON_ONCE instead of removing it
I am not sure this will get triggered more than once normally anyway, isn't it ?
> , but I
> don't think the backtrace is ever useful in this case.
Hmm, I am less concerned about backtraces than highlighting problem in a serious
way. The simple print messages are missed many times by people and probably
that's why I used a WARN instead.
> Empty table can
> be because eg. you run old DT on newer hardware version.
Hmm, but then a big warning isn't that bad as we need to highlight the issue to
everyone as cpufreq won't be working. isn't it ?
> This is why
> it's still communicated via dev_err().
--
viresh
next prev parent reply other threads:[~2020-01-07 11:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 19:36 [PATCH 1/2] opp: fix of_node leak for unsupported entries Michał Mirosław
2020-01-03 19:36 ` [PATCH 2/2] opp: quiet down WARN when no valid OPPs remain Michał Mirosław
2020-01-07 6:41 ` Viresh Kumar
2020-01-07 9:58 ` Michał Mirosław
2020-01-07 11:30 ` Viresh Kumar [this message]
2020-01-07 13:57 ` Michał Mirosław
2020-01-08 6:49 ` Viresh Kumar
2020-01-08 8:17 ` Viresh Kumar
2020-01-07 6:31 ` [PATCH 1/2] opp: fix of_node leak for unsupported entries Viresh Kumar
2020-01-07 6:36 ` Viresh Kumar
2020-01-07 14:04 ` Michał Mirosław
2020-01-08 7:33 ` Viresh Kumar
2020-01-08 10:38 ` Michał Mirosław
2020-01-08 10:44 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107113055.d4ebweisve73yf3m@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).