From: SeongJae Park <sjpark@amazon.com>
To: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
Cc: SeongJae Park <sjpark@amazon.com>, <brendanhiggins@google.com>,
<linux-kselftest@vger.kernel.org>, <kunit-dev@googlegroups.com>,
<linux-kernel@vger.kernel.org>,
SeongJae Park <sj38.park@gmail.com>
Subject: Re: Re: What is the best way to compare an unsigned and a constant?
Date: Tue, 7 Jan 2020 12:52:20 +0100 [thread overview]
Message-ID: <20200107115220.25574-1-sjpark@amazon.com> (raw)
In-Reply-To: <688d8f4b-266f-2c47-d4e9-d0336316a0a9@petrovitsch.priv.at>
On Fri, 27 Dec 2019 13:52:27 +0100 Bernd Petrovitsch <bernd@petrovitsch.priv.at> wrote:
> This is a multi-part message in MIME format.
> --------------D98A0A31D62B0BC2939BAEE9
> Content-Type: text/plain; charset=utf-8
> Content-Transfer-Encoding: quoted-printable
>
> Hi all!
>
> On 27/12/2019 13:39, SeongJae Park wrote:
> [...]
> > I have a function returning 'unsigned long', and would like to write a =
> kunit
> > test for the function, as below.
> >=20
> > unsigned long foo(void)
> > {
> > return 42;
> > }
> >=20
> > static void foo_test(struct kunit *test)
> > {
> > KUNIT_EXPECT_EQ(test, 42, foo());
> > }
>
> For this case: shouldn't=20
> ---- snip ----
> static void foo_test(struct kunit *test)
> {
> KUNIT_EXPECT_EQ(test, 42ul, foo());
> }
> ---- snip ----
> do the trick?
Unfortunately, it doesn't works.
[13:04:58] Building KUnit Kernel ...
In file included from /.../linux/include/linux/list.h:9:0,
from /.../linux/include/linux/wait.h:7,
from /.../linux/include/linux/wait_bit.h:8,
from /.../linux/include/linux/fs.h:6,
from /.../linux/include/linux/debugfs.h:15,
from /.../linux/mm/damon.c:12:
/.../linux/mm/damon-test.h: In function ‘damon_test_foo’:
/.../linux/include/linux/kernel.h:842:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
/.../linux/include/kunit/test.h:493:9: note: in expansion of macro ‘__typecheck’
((void)__typecheck(__left, __right)); \
^~~~~~~~~~~
/.../linux/include/kunit/test.h:517:2: note: in expansion of macro ‘KUNIT_BASE_BINARY_ASSERTION’
KUNIT_BASE_BINARY_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
/.../linux/include/kunit/test.h:606:2: note: in expansion of macro ‘KUNIT_BASE_EQ_MSG_ASSERTION’
KUNIT_BASE_EQ_MSG_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
/.../linux/include/kunit/test.h:616:2: note: in expansion of macro ‘KUNIT_BINARY_EQ_MSG_ASSERTION’
KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/.../linux/include/kunit/test.h:979:2: note: in expansion of macro ‘KUNIT_BINARY_EQ_ASSERTION’
KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
^~~~~~~~~~~~~~~~~~~~~~~~~
/.../linux/mm/damon-test.h:565:2: note: in expansion of macro ‘KUNIT_EXPECT_EQ’
KUNIT_EXPECT_EQ(test, 42ul, (int)foo());
^~~~~~~~~~~~~~~
Some other thoughts?
Thanks,
SeongJae Park
>
> MfG,
> Bernd
> --=20
> "I dislike type abstraction if it has no real reason. And saving
> on typing is not a good reason - if your typing speed is the main
> issue when you're coding, you're doing something seriously wrong."
> - Linus Torvalds
next prev parent reply other threads:[~2020-01-07 11:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 12:39 What is the best way to compare an unsigned and a constant? SeongJae Park
2019-12-27 12:52 ` Bernd Petrovitsch
2019-12-27 13:08 ` SeongJae Park
2020-01-07 11:52 ` SeongJae Park [this message]
2020-01-07 13:35 ` Brendan Higgins
2020-01-07 13:49 ` SeongJae Park
2020-01-08 14:12 ` Brendan Higgins
2020-01-08 14:26 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107115220.25574-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=bernd@petrovitsch.priv.at \
--cc=brendanhiggins@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sj38.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).