From: Robert Richter <rrichter@marvell.com>
To: Bhaskar Upadhaya <bhaskar.upadhaya.linux@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>,
Bhaskar Upadhaya <bupadhaya@marvell.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"Ganapatrao Prabhakerrao Kulkarni" <gkulkarni@marvell.com>
Subject: Re: [RFC PATCH] apei/ghes: fix ghes_poll_func by registering in non-deferrable mode
Date: Tue, 7 Jan 2020 13:04:29 +0000 [thread overview]
Message-ID: <20200107130421.6w67frcsllkblie2@rric.localdomain> (raw)
In-Reply-To: <CAEYJA6rPiBYnM4rT5WJnvTSrk6GBHeLYxK5OF5oxmeVxVepGGQ@mail.gmail.com>
On 07.01.20 16:33:24, Bhaskar Upadhaya wrote:
> On Mon, Jan 6, 2020 at 6:39 PM Borislav Petkov <bp@alien8.de> wrote:
> >
> > On Mon, Jan 06, 2020 at 04:33:19PM +0530, Bhaskar Upadhaya wrote:
> > > Definition of poll interval as per spec (referred ACPI 6.3):
> > > "Indicates the poll interval in milliseconds OSPM should use to
> > > periodically check the error source for the presence of an error
> > > condition."
> >
> > Please add that...
> >
> > > We are observing an issue in our ThunderX2 platforms wherein
> > > ghes_poll_func is not called within poll interval when timer is
> > > configured with TIMER_DEFERRABLE flag(For NO_HZ kernel) and hence we
> > > are losing the error records.
> >
> > ... and that to your commit message then, so that it is crystal clear
> > *why* you're making this change.
>
> Thanks Borislav, I will edit the commit message with you comments in
> the next patch.
> Can I get your Ack in the next patch ?
I guess Boris will apply the patch to his tree as maintainer, so no
need to ack it.
-Robert
next prev parent reply other threads:[~2020-01-07 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 7:03 [RFC PATCH] apei/ghes: fix ghes_poll_func by registering in non-deferrable mode Bhaskar Upadhaya
2020-01-02 10:49 ` Bhaskar Upadhaya
2020-01-02 18:01 ` Borislav Petkov
2020-01-06 11:03 ` Bhaskar Upadhaya
2020-01-06 13:09 ` Borislav Petkov
2020-01-07 11:03 ` Bhaskar Upadhaya
2020-01-07 13:04 ` Robert Richter [this message]
2020-01-07 20:02 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107130421.6w67frcsllkblie2@rric.localdomain \
--to=rrichter@marvell.com \
--cc=bhaskar.upadhaya.linux@gmail.com \
--cc=bp@alien8.de \
--cc=bupadhaya@marvell.com \
--cc=gkulkarni@marvell.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).