From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71D11C33C8C for ; Tue, 7 Jan 2020 13:21:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 430EB207E0 for ; Tue, 7 Jan 2020 13:21:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="kpMZwwj+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbgAGNVz (ORCPT ); Tue, 7 Jan 2020 08:21:55 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50584 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727559AbgAGNVz (ORCPT ); Tue, 7 Jan 2020 08:21:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CrkNjGazMW+zoOdGlarP5I4eBBOORn1ZisIsMHSTOR8=; b=kpMZwwj+gfZ7Ut8xreJoKRuJxE qI/81PKNiiLyo+J4nuq5VkeUfwJMKcK/phV4qUNMGN09W4sSUttlRz1dMqvDqNlxQrbCvNK3Z/Jxz eyo4StP9zAU1MpxiTi/QXuVMYhwcIWeks1/aEeNqWbWbfCjsURkRAMteEDszISNSCwP0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1ioonu-0007uq-JR; Tue, 07 Jan 2020 14:21:50 +0100 Date: Tue, 7 Jan 2020 14:21:50 +0100 From: Andrew Lunn To: Johnson CH Chen =?utf-8?B?KOmZs+aYreWLsyk=?= Cc: "claudiu.manoil@nxp.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "zero19850401@gmail.com" Subject: Re: [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a Message-ID: <20200107132150.GB23819@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c > index 72868a28b621..ab4e45199df9 100644 > --- a/drivers/net/ethernet/freescale/gianfar.c > +++ b/drivers/net/ethernet/freescale/gianfar.c > @@ -833,6 +833,7 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev) > > /* Find the TBI PHY. If it's not there, we don't support SGMII */ > priv->tbi_node = of_parse_phandle(np, "tbi-handle", 0); > + priv->dma_endian_le = of_property_read_bool(np, "fsl,dma-endian-le"); Hi Johnson You need to document this new property in the binding. Thanks Andrew