From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E76BC33C9E for ; Tue, 7 Jan 2020 14:04:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09219208C4 for ; Tue, 7 Jan 2020 14:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl header.b="iiXv+F6/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbgAGOEx (ORCPT ); Tue, 7 Jan 2020 09:04:53 -0500 Received: from rere.qmqm.pl ([91.227.64.183]:2519 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727658AbgAGOEx (ORCPT ); Tue, 7 Jan 2020 09:04:53 -0500 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 47sYzQ4YNdz81; Tue, 7 Jan 2020 15:04:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1578405890; bh=XfoQMUnXZ3Glt0sRfyK+w1caLMhptVW6zmno8kSOLR4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iiXv+F6/UQ1utYIz0/MoMQiF00RNjS+x1Y13YR+LMrW23hG+aZM+pDS14pDXDyUtN QXjGg6DdaJBUSKsVIG1/1k+KOE2bgrPre75Yfg4L2X7iOSmAtY4YXX+S+LYNXrTMHn kRlU3FVIisXO0hoc3nwgsF1eWQuTcrlelzf1E/gqsQQdKBH55ozSTZ9eHukMvxgpMs H6lKUnyEsMWDDMQOt9WWbFo0kd3wzO7CnAa2kjmT2eyV3t2OSnyq0aVq5ys0+is7V2 IcgWiuhp64/gJ1x4YFZJ9Rw4riP6UC9KI3s4dZKMiU8M6n7TZTCplDML+0weDNIWyU cK+dk4iclft3Q== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.101.4 at mail Date: Tue, 7 Jan 2020 15:04:49 +0100 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Viresh Kumar Cc: Nishanth Menon , Stephen Boyd , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] opp: fix of_node leak for unsupported entries Message-ID: <20200107140449.GB20159@qmqm.qmqm.pl> References: <20200107063616.a3qpepc46viejxhw@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200107063616.a3qpepc46viejxhw@vireshk-i7> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2020 at 12:06:16PM +0530, Viresh Kumar wrote: > Discard my earlier reply, it wasn't accurate/correct. > > On 03-01-20, 20:36, Michał Mirosław wrote: > > When parsing OPP v2 table, unsupported entries return NULL from > > _opp_add_static_v2(). > > Right, as we don't want parsing to fail here. > > > In this case node reference is leaked. > > Why do you think so ? for_each_available_child_of_node() returns nodes with refcount increased, and _opp_add_static_v2() returning NULL does not store the pointer anywhere - the created (temporary) OPP structure is freed, but _opp_free() does not release node at opp->np. I guess maybe the _opp_free() should be fixed instead? Best Regards, Michał Mirosław