From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E374DC33C9E for ; Wed, 8 Jan 2020 06:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA4642077B for ; Wed, 8 Jan 2020 06:49:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oRQZMXS5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726323AbgAHGtG (ORCPT ); Wed, 8 Jan 2020 01:49:06 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43752 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbgAHGtF (ORCPT ); Wed, 8 Jan 2020 01:49:05 -0500 Received: by mail-pf1-f196.google.com with SMTP id x6so1101969pfo.10 for ; Tue, 07 Jan 2020 22:49:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=XfnflGZ6oSzY+MaLoyJpJ8yAdxfSU+oZoFb75ber0eQ=; b=oRQZMXS5BPcdeOERB4pNNVbYLVT8+DpXr8U+UcJ8gw8uIslp6j9jSsr429ZOJAxoji +pN9S6F601Z1Uf/ZHSEYWRtIWlrqgqOzr/7raG+viem8rqLoQldnlqfii7cCy7BJ8ZCq PBw7/QsasSqrNRZtBQdl5xCSy3mOELWFD0GZ+Fg+9wml4PjmonL6bDfrq0BDCA7KDZ91 YhxAYp+gPmz7GP5dxOMgKS4j6+Fc+HiYliG6oQH4I1Qapr0TVhg+ZUfXGK4RnwDeKBR/ ETwk/VfGEpW8zJ0Lkj6lZ2sWswLcbkOgb2mQwjKObo195/u6ho3YaEiJa59eQFpldVMG tbUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=XfnflGZ6oSzY+MaLoyJpJ8yAdxfSU+oZoFb75ber0eQ=; b=SCBy9V5KhwohF9ebvMenS5g8mI+PwlPMH+i4lGqFTVELrC6URArBXwNjfheDCQ4F0I BZtvsSkWu5eIHJgBS+TMKgvTLlD9X3QwkDEPkZ9yfwks48tZt182GkNngg2CHpgw04g7 +/HZbA4TV5T7CLzreOQ0vbflGn8w+DGuTpKXT3nK4hZA1gkzT5o2isZOnYcrEPRxeL5z dO1R6/SH9mL6s1x2bPLN3DynVs21WIAFcEavrBpkgmu2xHY22JpmKOe0rfsPfdzoYDoK 1UjyIvvslfALXEKQZcyYeTW4U/mzsGLSJ57uzU6yWNI6qkBpirerjla4qwB3XTHHGPrs piuA== X-Gm-Message-State: APjAAAXwKFzyqPbFovhXS4YM6x5500mZWnDCXZqKrgdONmi0nKH5CNOC m1H7kAPRTL1kw5wNczM9mHverQ== X-Google-Smtp-Source: APXvYqwihXTTTzoaBd499RsWz0IN7S6x7DMn+MdqYf7L1dPxI2620/DVar1McatTo8xPCGImgowKtA== X-Received: by 2002:a65:5786:: with SMTP id b6mr3737898pgr.316.1578466144857; Tue, 07 Jan 2020 22:49:04 -0800 (PST) Received: from localhost ([122.172.26.121]) by smtp.gmail.com with ESMTPSA id s24sm1670546pjp.17.2020.01.07.22.49.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2020 22:49:04 -0800 (PST) Date: Wed, 8 Jan 2020 12:19:01 +0530 From: Viresh Kumar To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: Nishanth Menon , Stephen Boyd , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] opp: quiet down WARN when no valid OPPs remain Message-ID: <20200108064901.rf6r7buy6tcxsrzc@vireshk-i7> References: <5c2d6548aef35c690535fd8c985b980316745e91.1578077228.git.mirq-linux@rere.qmqm.pl> <20200107064128.gkeq2ejtvx4bmyhj@vireshk-i7> <20200107095834.GB3515@qmqm.qmqm.pl> <20200107113055.d4ebweisve73yf3m@vireshk-i7> <20200107135743.GA20159@qmqm.qmqm.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200107135743.GA20159@qmqm.qmqm.pl> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07-01-20, 14:57, Michał Mirosław wrote: > On Tue, Jan 07, 2020 at 05:00:55PM +0530, Viresh Kumar wrote: > > On 07-01-20, 10:58, Michał Mirosław wrote: > > > On Tue, Jan 07, 2020 at 12:11:29PM +0530, Viresh Kumar wrote: > > > > On 03-01-20, 20:36, Michał Mirosław wrote: > > > > > Per CPU screenful of backtraces is not really that useful. Replace > > > > > WARN with a diagnostic discriminating common causes of empty OPP table. > > > > But why should a platform have an OPP table in DT where none of them works for > > > > it ? I added the warn intentionally here just for that case. > > > Hmm. I guess we can make it WARN_ON_ONCE instead of removing it > > I am not sure this will get triggered more than once normally anyway, isn't it ? > > It is triggered once per core. What platform it is ? Maybe because cpufreq driver failed to initialize the policy for all CPUs and so this is getting repeated. > > > , but I > > > don't think the backtrace is ever useful in this case. > > Hmm, I am less concerned about backtraces than highlighting problem in a serious > > way. The simple print messages are missed many times by people and probably > > that's why I used a WARN instead. > > > > > > Empty table can > > > be because eg. you run old DT on newer hardware version. > > > > Hmm, but then a big warning isn't that bad as we need to highlight the issue to > > everyone as cpufreq won't be working. isn't it ? > > A user normally can't do much about it. Rather this is a developer targeted > message. Maybe a rewording of the messages be better? Something to also > include consequences of the error? I agree that a WARN may be a bit excessive here. -- viresh