From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FFADC00523 for ; Wed, 8 Jan 2020 07:52:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BADF206F0 for ; Wed, 8 Jan 2020 07:52:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726955AbgAHHw5 (ORCPT ); Wed, 8 Jan 2020 02:52:57 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:38135 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbgAHHw5 (ORCPT ); Wed, 8 Jan 2020 02:52:57 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ip696-0006TA-I9; Wed, 08 Jan 2020 08:52:52 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ip691-0007Fs-TD; Wed, 08 Jan 2020 08:52:47 +0100 Date: Wed, 8 Jan 2020 08:52:47 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Fabio Estevam Cc: Andrew Lunn , Peng Fan , "jason@lakedaemon.net" , "linus.walleij@linaro.org" , "linux-kernel@vger.kernel.org" , "mripard@kernel.org" , "linux-gpio@vger.kernel.org" , "wens@csie.org" , "gregory.clement@bootlin.com" , "linux-arm-kernel@lists.infradead.org" , "sebastian.hesselbarth@gmail.com" Subject: Re: [PATCH 1/2] pinctrl: mvebu: armada-37xx: use use platform api Message-ID: <20200108075247.y5ex44flp6lvqeoc@pengutronix.de> References: <1576672860-14420-1-git-send-email-peng.fan@nxp.com> <20191218145955.GE26938@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Fabio, On Wed, Dec 18, 2019 at 12:09:42PM -0300, Fabio Estevam wrote: > On Wed, Dec 18, 2019 at 12:00 PM Andrew Lunn wrote: > > > Hi Fabio > > > > Look closer. This is not about returning an error, it is about > > printing an error. > > > > I think the API could better. A %ie formatter would make a lot of > > sense, so avoiding the ERR_PTR(). > > Yes, I think that returning the error like: > > dev_err(dev, "Couldn't determine irq count: %d\n", nr_irq_parent); > > would make the code cleaner. Are you aware of the semantic difference between dev_err(..., "Couldn't determine irq count: %d\n", nr_irq_parent); and dev_err(..., "Couldn't determine irq count: %pe\n", ERR_PTR(nr_irq_parent)); ? The first yields: Couldn't determine irq count: -5 while the latter yields Couldn't determine irq count: -EIO which is more expressive. I agree that having a format for printing an integer error code would be useful. I have this on my todo-list but having some %pe with ERR_PTR conversion would help me arguing my case. So I would like the patch to go in with ERR_PTR even though v2 was sent using %d today. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |