From: Steven Price <steven.price@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the akpm tree
Date: Wed, 8 Jan 2020 14:52:49 +0000 [thread overview]
Message-ID: <20200108145248.GA2584@arm.com> (raw)
In-Reply-To: <20200107151107.1ffae482a8663ada2bbc3bd3@linux-foundation.org>
On Tue, Jan 07, 2020 at 11:11:07PM +0000, Andrew Morton wrote:
> On Mon, 6 Jan 2020 17:07:44 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > Hi all,
> >
> > After merging the akpm tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > arch/x86/mm/dump_pagetables.c: In function 'ptdump_walk_pgd_level_core':
> > arch/x86/mm/dump_pagetables.c:403:1: warning: the frame size of 2128 bytes is larger than 2048 bytes [-Wframe-larger-than=]
> > 403 | }
> > | ^
> >
> > Introduced by commit
> >
> > 710fae4f03f2 ("x86: mm: convert dump_pagetables to use walk_page_range")
> >
>
> (gdb) p sizeof(struct mm_struct)
> $1 = 1664
>
> yup, that'll do it.
Ok, looks like I'll have to do something a little bit more clever than
the "fake_mm" hack I used before. The trouble is x86 now has two PGDs
due to the PAGE_TABLE_ISOLATION feature. I was trying to isolate this
quirk to the x86 code, but it looks like we need some way of passing an
"override" down for the PGD.
I'll post a possible fix as a reply to this post.
Steve
next prev parent reply other threads:[~2020-01-08 14:52 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 6:07 linux-next: build warning after merge of the akpm tree Stephen Rothwell
2020-01-07 23:11 ` Andrew Morton
2020-01-08 14:52 ` Steven Price [this message]
2020-01-08 14:57 ` [PATCH] x86: mm: Avoid allocating struct mm_struct on the stack Steven Price
-- strict thread matches above, loose matches on Subject: below --
2021-01-28 8:46 linux-next: build warning after merge of the akpm tree Stephen Rothwell
2021-02-01 7:14 ` Vijayanand Jitta
2020-12-04 10:00 Stephen Rothwell
2020-12-05 5:19 ` Andrew Morton
2020-12-05 9:37 ` Stephen Rothwell
2020-12-07 12:08 ` Dmitry Vyukov
2020-12-07 12:38 ` Dmitry Vyukov
2020-12-07 12:52 ` Marco Elver
2020-12-09 10:06 ` Dmitry Vyukov
2020-12-08 12:01 ` Stephen Rothwell
2020-12-09 4:44 ` Michael Ellerman
2020-12-09 7:07 ` Stephen Rothwell
2020-12-10 0:19 ` Michael Ellerman
2020-12-10 21:17 ` Stephen Rothwell
2020-12-09 10:33 ` Stephen Rothwell
2020-12-09 18:56 ` Kees Cook
2020-02-28 4:35 Stephen Rothwell
2020-02-28 5:23 ` Arjun Roy
2020-01-06 6:11 Stephen Rothwell
2018-11-30 5:40 Stephen Rothwell
2018-11-30 14:52 ` Dave Rodgman
2017-08-01 6:02 Stephen Rothwell
2017-08-01 6:15 ` Huang, Ying
2017-08-01 21:15 ` Arnd Bergmann
2017-06-26 6:30 Stephen Rothwell
2017-06-26 23:57 ` Wei Yang
2014-05-19 8:13 Stephen Rothwell
2014-05-19 15:13 ` Davidlohr Bueso
2014-05-19 19:48 ` Andrew Morton
2014-05-19 20:56 ` Davidlohr Bueso
2014-05-19 21:17 ` Andrew Morton
2014-05-19 21:36 ` Stephen Rothwell
2014-05-19 22:38 ` Davidlohr Bueso
2013-04-18 8:03 Stephen Rothwell
2013-04-10 8:33 Stephen Rothwell
2013-04-10 8:18 Stephen Rothwell
2013-02-20 6:34 Stephen Rothwell
2013-02-20 14:37 ` Peter Jones
2013-01-23 6:33 Stephen Rothwell
2013-01-23 6:43 ` Tang Chen
2012-11-09 3:43 Stephen Rothwell
2012-11-09 10:00 ` Grant Likely
2012-10-25 3:35 Stephen Rothwell
2012-04-27 5:44 Stephen Rothwell
2012-04-27 6:22 ` Cyrill Gorcunov
2012-04-27 6:28 ` Stephen Rothwell
2012-04-27 6:40 ` Cyrill Gorcunov
2011-08-10 2:13 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108145248.GA2584@arm.com \
--to=steven.price@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).