From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B7F8C33CA2 for ; Wed, 8 Jan 2020 15:02:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 486472072A for ; Wed, 8 Jan 2020 15:02:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728426AbgAHPCs (ORCPT ); Wed, 8 Jan 2020 10:02:48 -0500 Received: from verein.lst.de ([213.95.11.211]:49671 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbgAHPCs (ORCPT ); Wed, 8 Jan 2020 10:02:48 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 5230B68BFE; Wed, 8 Jan 2020 16:02:45 +0100 (CET) Date: Wed, 8 Jan 2020 16:02:45 +0100 From: "hch@lst.de" To: Chaitanya Kulkarni Cc: Balbir Singh , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "axboe@kernel.dk" , "ssomesh@amazon.com" , "jejb@linux.ibm.com" , "hch@lst.de" , "mst@redhat.com" Subject: Re: [resend v1 1/5] block/genhd: Notify udev about capacity change Message-ID: <20200108150245.GA10975@lst.de> References: <20200102075315.22652-1-sblbir@amazon.com> <20200102075315.22652-2-sblbir@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 03, 2020 at 06:16:39AM +0000, Chaitanya Kulkarni wrote: > Since disk_set_capacity(() is on the same line as set_capacity() > we should follow the same convention, which is :- > > 1. Avoid exporting symbol. > 2. Mark new function in-line. > > Unless there is a very specific reason for breaking the pattern. Why would we mark it as inline? It isn't by any means in the fast path, and there are no easy opportunities for constant propagation, so the only thing that would do is increase the code size.