From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6087C33CA2 for ; Wed, 8 Jan 2020 18:09:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CA0D2067D for ; Wed, 8 Jan 2020 18:09:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730156AbgAHSJB (ORCPT ); Wed, 8 Jan 2020 13:09:01 -0500 Received: from mga05.intel.com ([192.55.52.43]:52644 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726781AbgAHSJB (ORCPT ); Wed, 8 Jan 2020 13:09:01 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2020 10:09:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,410,1571727600"; d="scan'208";a="421521020" Received: from tfeiten-mobl1.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.252.37.105]) by fmsmga005.fm.intel.com with ESMTP; 08 Jan 2020 10:08:56 -0800 Received: by kekkonen.fi.intel.com (Postfix, from userid 1000) id B962521EDA; Wed, 8 Jan 2020 20:08:54 +0200 (EET) Date: Wed, 8 Jan 2020 20:08:54 +0200 From: Sakari Ailus To: Helen Koike Cc: linux-rockchip@lists.infradead.org, mark.rutland@arm.com, devicetree@vger.kernel.org, eddie.cai.linux@gmail.com, mchehab@kernel.org, heiko@sntech.de, gregkh@linuxfoundation.org, andrey.konovalov@linaro.org, linux-kernel@vger.kernel.org, tfiga@chromium.org, robh+dt@kernel.org, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, joacim.zetterling@gmail.com, kernel@collabora.com, ezequiel@collabora.com, linux-media@vger.kernel.org, jacob-chen@iotwrt.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v12 08/11] media: staging: dt-bindings: add Rockchip ISP1 yaml bindings Message-ID: <20200108180854.GA5438@kekkonen.localdomain> References: <20191227200116.2612137-1-helen.koike@collabora.com> <20191227200116.2612137-9-helen.koike@collabora.com> <20200107140115.GQ19828@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 08, 2020 at 01:50:38PM -0300, Helen Koike wrote: > Hi, > > Thank you for your review. > > On 1/7/20 12:01 PM, Sakari Ailus wrote: > > Hi Helen, > > > > On Fri, Dec 27, 2019 at 05:01:13PM -0300, Helen Koike wrote: > >> Add yaml DT bindings for Rockchip ISP1. > >> > >> This was tested and verified with: > >> mv drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml Documentation/devicetree/bindings/media/ > >> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml > >> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml > >> > >> Signed-off-by: Helen Koike > >> > >> --- > >> > >> Changes in v12: > >> - The commit replaces the following commit in previous series named > >> media: staging: dt-bindings: Document the Rockchip ISP1 bindings > >> This new patch adds yaml binding and was verified with > >> make dtbs_check and make dt_binding_check > >> > >> Changes in v11: > >> - add clock-names values > >> > >> Changes in v10: > >> - unsquash > >> > >> Changes in v9: > >> - squash > >> - move to staging > >> > >> Changes in v8: > >> - fix title division style > >> > >> Changes in v7: > >> - update document with new design and tested example > >> > >> .../bindings/media/rockchip-isp1.yaml | 193 ++++++++++++++++++ > >> 1 file changed, 193 insertions(+) > >> create mode 100644 drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > >> > >> diff --git a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > >> new file mode 100644 > >> index 000000000000..4d1b2c67a4cd > >> --- /dev/null > >> +++ b/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > >> @@ -0,0 +1,193 @@ > >> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/media/rockchip-isp1.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Rockchip SoC Image Signal Processing unit v1 > >> + > >> +maintainers: > >> + - Helen Koike > >> + > >> +description: | > >> + Rockchip ISP1 is the Camera interface for the Rockchip series of SoCs > >> + which contains image processing, scaling, and compression funcitons. > > > > "functions" > > > >> + > >> +properties: > >> + compatible: > >> + const: rockchip,rk3399-cif-isp > >> + > >> + reg: > >> + maxItems: 1 > >> + > >> + interrupts: > >> + maxItems: 1 > >> + > >> + iommus: > >> + maxItems: 1 > >> + > >> + power-domains: > >> + maxItems: 1 > >> + > >> + phys: > >> + maxItems: 1 > >> + description: phandle for the PHY port > >> + > >> + phy-names: > >> + const: dphy > >> + > >> + clocks: > >> + items: > >> + - description: ISP clock > >> + - description: ISP aclk clock > >> + - description: ISP aclk wrapper clock > >> + - description: ISP hclk clock > >> + - description: ISP hclk wrapper clock > >> + > >> + clock-names: > >> + items: > >> + - const: clk_isp > >> + - const: aclk_isp > >> + - const: aclk_isp_wrap > >> + - const: hclk_isp > >> + - const: hclk_isp_wrap > >> + > >> + # See ./video-interfaces.txt for details > >> + ports: > >> + type: object > >> + additionalProperties: false > >> + > >> + properties: > >> + "#address-cells": > >> + const: 1 > >> + > >> + "#size-cells": > >> + const: 0 > >> + > >> + port@0: > > > > If you only have a single port node, you could drop reg as well as @0 on > > the port node. > > After the discussions, we have a single port for now, but we might have port@1 > for tx1rx1 in the future. Ack. Please keep it as-is then. -- Sakari Ailus sakari.ailus@linux.intel.com