From: Helen Koike <helen.koike@collabora.com>
To: linux-rockchip@lists.infradead.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
eddie.cai.linux@gmail.com, mchehab@kernel.org, heiko@sntech.de,
gregkh@linuxfoundation.org, andrey.konovalov@linaro.org,
linux-kernel@vger.kernel.org, tfiga@chromium.org,
robh+dt@kernel.org, hans.verkuil@cisco.com,
laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
joacim.zetterling@gmail.com, kernel@collabora.com,
ezequiel@collabora.com, linux-media@vger.kernel.org,
jacob-chen@iotwrt.com, linux-arm-kernel@lists.infradead.org,
Helen Koike <helen.koike@collabora.com>
Subject: [PATCH v13 00/11] Rockchip ISP Driver
Date: Wed, 8 Jan 2020 15:44:43 -0300 [thread overview]
Message-ID: <20200108184454.825725-1-helen.koike@collabora.com> (raw)
Hi,
This patchset adds support for the Image Signal Processor unit version 1.0 of
the Rockchip RK3399 SoC in the staging tree.
There are still some missing things to move it from staging (please, see
TODO file), but the driver is already being used by several people.
For instance, libcamera, currently supports an older version of the driver;
and adding in staging make the work flow easier for collaboration within
the community.
I plan to be actively working on the driver to move it out of staging as soon as possible.
It is also available at
https://gitlab.collabora.com/koike/linux/tree/rockchip/isp/v13
NOTE: This series only touches MAINTAINERS file and drivers/staging/
Major changes in v13
--------------------
* From v12 discussions, this dphy driver will only be used for rx0, as
the tx1rx1 will be provided by the dsi controller driver as pointed by
Heiko. So in this version we renamed the driver from phy-rockchip-dphy
to phy-rockchip-dphy-rx0, we also renamed the configs and the bindings,
to make it clear it is specific to rx0.
* Fixed typo and improved text descriptions as pointed by Laurent, Ezequiel
and Sakari in v12.
* Removed redundant TESTCLK=1.
* Replaced do_div by div_u64 for data_rate calculation.
* Removed useless grf lookup by phandle.
* Removed space from bus info, to make it "platform:rkisp1", similar to
"platform:vivid" and "platform:vimc".
* Minor coding style changes.
Diff from v12 to v13 can be viewed here: http://ix.io/26Qn
Commands output:
----------------
media-ctl -p : http://ix.io/25DG
media-ctl --print-dot: http://col.la/rkisp1v12dot
v4l2-compliance -m0: http://ix.io/25DI
NOTE: there is a failure in v4l2-compliance, but comes from the sensor, not from the ISP.
Testing:
--------
SEN_DEV=/dev/v4l-subdev3
ISP_DEV=/dev/v4l-subdev0
RSZ_SP_DEV=/dev/v4l-subdev2
RSZ_MP_DEV=/dev/v4l-subdev1
CAP_SP_DEV=/dev/video1
CAP_MP_DEV=/dev/video0
WIDTH=1280
HEIGHT=960
v4l2-ctl --set-subdev-fmt pad=0,width=$WIDTH,height=$HEIGHT,code=0x3001 -d $SEN_DEV
v4l2-ctl --set-subdev-fmt pad=0,width=$WIDTH,height=$HEIGHT,code=0x3001 -d $ISP_DEV
v4l2-ctl --set-subdev-selection pad=0,target=crop,top=0,left=0,width=$WIDTH,height=$HEIGHT -d $ISP_DEV
v4l2-ctl --set-subdev-selection pad=2,target=crop,top=0,left=0,width=$WIDTH,height=$HEIGHT -d $ISP_DEV
v4l2-ctl --set-subdev-fmt pad=2,width=$WIDTH,height=$HEIGHT,code=0x2008 -d $ISP_DEV
v4l2-ctl --set-subdev-fmt pad=0,width=$WIDTH,height=$HEIGHT,code=0x2008 -d $RSZ_SP_DEV
v4l2-ctl --set-subdev-fmt pad=1,width=$WIDTH,height=$HEIGHT,code=0x2008 -d $RSZ_SP_DEV
v4l2-ctl --set-subdev-selection pad=0,target=crop,top=0,left=0,width=$WIDTH,height=$HEIGHT -d $RSZ_SP_DEV
v4l2-ctl --set-subdev-fmt pad=0,width=$WIDTH,height=$HEIGHT,code=0x2008 -d $RSZ_MP_DEV
v4l2-ctl --set-subdev-fmt pad=1,width=$WIDTH,height=$HEIGHT,code=0x2008 -d $RSZ_MP_DEV
v4l2-ctl --set-subdev-selection pad=0,target=crop,top=0,left=0,width=$WIDTH,height=$HEIGHT -d $RSZ_MP_DEV
v4l2-ctl -v width=$WIDTH,height=$HEIGHT,pixelformat=NV12 -d $CAP_SP_DEV
v4l2-ctl -v width=$WIDTH,height=$HEIGHT,pixelformat=NV12 -d $CAP_MP_DEV
v4l2-ctl --stream-mmap --stream-count=100 -d $CAP_SP_DEV --stream-to=/tmp/test_sp.raw
v4l2-ctl --stream-mmap --stream-count=100 -d $CAP_MP_DEV --stream-to=/tmp/test_mp.raw
ffplay -loglevel warning -v info -f rawvideo -pixel_format nv12 -video_size "1280x960" tmp/test_sp.raw
ffplay -loglevel warning -v info -f rawvideo -pixel_format nv12 -video_size "1280x960" tmp/test_mp.raw
Thanks
Helen
Ezequiel Garcia (1):
media: staging: phy-rockchip-dphy-rx0: add Rockchip MIPI Synopsys DPHY
RX0 driver
Helen Koike (6):
media: staging: rkisp1: add Rockchip ISP1 base driver
media: staging: rkisp1: add streaming paths
media: staging: dt-bindings: add Rockchip ISP1 yaml bindings
media: staging: dt-bindings: add Rockchip MIPI RX D-PHY RX0 yaml
bindings
media: staging: rkisp1: add TODO file for staging
MAINTAINERS: add entry for Rockchip ISP1 driver
Jacob Chen (3):
media: staging: rkisp1: add capture device for statistics
media: staging: rkisp1: add output device for parameters
media: staging: rkisp1: add document for rkisp1 meta buffer format
Jeffy Chen (1):
media: staging: rkisp1: add user space ABI definitions
MAINTAINERS | 6 +
drivers/staging/media/Kconfig | 4 +
drivers/staging/media/Makefile | 2 +
.../bindings/phy/rockchip-mipi-dphy-rx0.yaml | 76 +
.../media/phy-rockchip-dphy-rx0/Kconfig | 13 +
.../media/phy-rockchip-dphy-rx0/Makefile | 2 +
.../staging/media/phy-rockchip-dphy-rx0/TODO | 6 +
.../phy-rockchip-dphy-rx0.c | 388 ++++
.../bindings/media/rockchip-isp1.yaml | 192 ++
.../uapi/v4l/pixfmt-meta-rkisp1-params.rst | 23 +
.../uapi/v4l/pixfmt-meta-rkisp1-stat.rst | 22 +
drivers/staging/media/rkisp1/Kconfig | 17 +
drivers/staging/media/rkisp1/Makefile | 8 +
drivers/staging/media/rkisp1/TODO | 23 +
drivers/staging/media/rkisp1/rkisp1-capture.c | 1437 +++++++++++++++
drivers/staging/media/rkisp1/rkisp1-common.c | 37 +
drivers/staging/media/rkisp1/rkisp1-common.h | 337 ++++
drivers/staging/media/rkisp1/rkisp1-dev.c | 574 ++++++
drivers/staging/media/rkisp1/rkisp1-isp.c | 1164 ++++++++++++
drivers/staging/media/rkisp1/rkisp1-params.c | 1630 +++++++++++++++++
drivers/staging/media/rkisp1/rkisp1-regs.h | 1264 +++++++++++++
drivers/staging/media/rkisp1/rkisp1-resizer.c | 775 ++++++++
drivers/staging/media/rkisp1/rkisp1-stats.c | 530 ++++++
.../staging/media/rkisp1/uapi/rkisp1-config.h | 819 +++++++++
24 files changed, 9349 insertions(+)
create mode 100644 drivers/staging/media/phy-rockchip-dphy-rx0/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
create mode 100644 drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig
create mode 100644 drivers/staging/media/phy-rockchip-dphy-rx0/Makefile
create mode 100644 drivers/staging/media/phy-rockchip-dphy-rx0/TODO
create mode 100644 drivers/staging/media/phy-rockchip-dphy-rx0/phy-rockchip-dphy-rx0.c
create mode 100644 drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
create mode 100644 drivers/staging/media/rkisp1/Documentation/media/uapi/v4l/pixfmt-meta-rkisp1-params.rst
create mode 100644 drivers/staging/media/rkisp1/Documentation/media/uapi/v4l/pixfmt-meta-rkisp1-stat.rst
create mode 100644 drivers/staging/media/rkisp1/Kconfig
create mode 100644 drivers/staging/media/rkisp1/Makefile
create mode 100644 drivers/staging/media/rkisp1/TODO
create mode 100644 drivers/staging/media/rkisp1/rkisp1-capture.c
create mode 100644 drivers/staging/media/rkisp1/rkisp1-common.c
create mode 100644 drivers/staging/media/rkisp1/rkisp1-common.h
create mode 100644 drivers/staging/media/rkisp1/rkisp1-dev.c
create mode 100644 drivers/staging/media/rkisp1/rkisp1-isp.c
create mode 100644 drivers/staging/media/rkisp1/rkisp1-params.c
create mode 100644 drivers/staging/media/rkisp1/rkisp1-regs.h
create mode 100644 drivers/staging/media/rkisp1/rkisp1-resizer.c
create mode 100644 drivers/staging/media/rkisp1/rkisp1-stats.c
create mode 100644 drivers/staging/media/rkisp1/uapi/rkisp1-config.h
--
2.24.0
next reply other threads:[~2020-01-08 18:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 18:44 Helen Koike [this message]
2020-01-08 18:44 ` [PATCH v13 01/11] media: staging: phy-rockchip-dphy-rx0: add Rockchip MIPI Synopsys DPHY RX0 driver Helen Koike
2020-01-08 18:44 ` [PATCH v13 02/11] media: staging: rkisp1: add Rockchip ISP1 base driver Helen Koike
2020-01-08 18:44 ` [PATCH v13 03/11] media: staging: rkisp1: add streaming paths Helen Koike
2020-01-08 18:44 ` [PATCH v13 04/11] media: staging: rkisp1: add user space ABI definitions Helen Koike
2020-01-08 18:44 ` [PATCH v13 05/11] media: staging: rkisp1: add capture device for statistics Helen Koike
2020-01-08 18:44 ` [PATCH v13 06/11] media: staging: rkisp1: add output device for parameters Helen Koike
2020-01-08 18:44 ` [PATCH v13 07/11] media: staging: rkisp1: add document for rkisp1 meta buffer format Helen Koike
2020-01-08 18:44 ` [PATCH v13 08/11] media: staging: dt-bindings: add Rockchip ISP1 yaml bindings Helen Koike
2020-01-08 18:44 ` [PATCH v13 09/11] media: staging: dt-bindings: add Rockchip MIPI RX D-PHY RX0 " Helen Koike
2020-01-08 18:44 ` [PATCH v13 10/11] media: staging: rkisp1: add TODO file for staging Helen Koike
2020-01-08 18:44 ` [PATCH v13 11/11] MAINTAINERS: add entry for Rockchip ISP1 driver Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108184454.825725-1-helen.koike@collabora.com \
--to=helen.koike@collabora.com \
--cc=andrey.konovalov@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=ezequiel@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=joacim.zetterling@gmail.com \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).