From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephane Eranian <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 8/9] perf top: Add --all-cgroups option
Date: Wed, 8 Jan 2020 23:24:58 +0100 [thread overview]
Message-ID: <20200108222458.GF12995@krava> (raw)
In-Reply-To: <20200107133501.327117-9-namhyung@kernel.org>
On Tue, Jan 07, 2020 at 10:35:00PM +0900, Namhyung Kim wrote:
> The --all-cgroups option is to enable cgroup profiling support. It
> tells kernel to record CGROUP events in the ring buffer so that perf
> report can identify task/cgroup association later.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/Documentation/perf-top.txt | 4 ++++
> tools/perf/builtin-top.c | 9 +++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
> index 5596129a71cf..c75507f50071 100644
> --- a/tools/perf/Documentation/perf-top.txt
> +++ b/tools/perf/Documentation/perf-top.txt
> @@ -266,6 +266,10 @@ Default is to monitor all CPUS.
> Record events of type PERF_RECORD_NAMESPACES and display it with the
> 'cgroup_id' sort key.
>
> +--cgroup::
> + Record events of type PERF_RECORD_CGROUP and display it with the
> + 'cgroup' sort key.
should be '--all-cgroups' ?
anyway, we dont have '--cgroups', why not use just this?
jirka
> +
> --switch-on EVENT_NAME::
> Only consider events after this event is found.
>
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 795e353de095..f6256c533b09 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -1244,6 +1244,8 @@ static int __cmd_top(struct perf_top *top)
>
> if (opts->record_namespaces)
> top->tool.namespace_events = true;
> + if (opts->record_cgroup)
> + top->tool.cgroup_events = true;
>
> ret = perf_event__synthesize_bpf_events(top->session, perf_event__process,
> &top->session->machines.host,
> @@ -1251,6 +1253,11 @@ static int __cmd_top(struct perf_top *top)
> if (ret < 0)
> pr_debug("Couldn't synthesize BPF events: Pre-existing BPF programs won't have symbols resolved.\n");
>
> + ret = perf_event__synthesize_cgroups(&top->tool, perf_event__process,
> + &top->session->machines.host);
> + if (ret < 0)
> + pr_debug("Couldn't synthesize cgroup events.\n");
> +
> machine__synthesize_threads(&top->session->machines.host, &opts->target,
> top->evlist->core.threads, false,
> top->nr_threads_synthesize);
> @@ -1539,6 +1546,8 @@ int cmd_top(int argc, const char **argv)
> "number of thread to run event synthesize"),
> OPT_BOOLEAN(0, "namespaces", &opts->record_namespaces,
> "Record namespaces events"),
> + OPT_BOOLEAN(0, "all-cgroups", &opts->record_cgroup,
> + "Record cgroup events"),
> OPTS_EVSWITCH(&top.evswitch),
> OPT_END()
> };
> --
> 2.24.1.735.g03f4e72817-goog
>
next prev parent reply other threads:[~2020-01-08 22:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 13:34 [PATCHSET 0/9] perf: Improve cgroup profiling (v4) Namhyung Kim
2020-01-07 13:34 ` [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event Namhyung Kim
2020-01-07 13:34 ` [PATCH 2/9] perf/core: Add PERF_SAMPLE_CGROUP feature Namhyung Kim
2020-01-07 13:34 ` [PATCH 3/9] perf tools: Basic support for CGROUP event Namhyung Kim
2020-01-07 13:34 ` [PATCH 4/9] perf tools: Maintain cgroup hierarchy Namhyung Kim
2020-01-08 21:52 ` Jiri Olsa
2020-01-09 0:51 ` Namhyung Kim
2020-01-20 13:57 ` Namhyung Kim
2020-01-21 9:42 ` Jiri Olsa
2020-02-17 15:46 ` Arnaldo Carvalho de Melo
2020-02-17 19:22 ` Namhyung Kim
2020-01-08 22:01 ` Jiri Olsa
2020-01-09 0:55 ` Namhyung Kim
2020-01-07 13:34 ` [PATCH 5/9] perf report: Add 'cgroup' sort key Namhyung Kim
2020-01-07 13:34 ` [PATCH 6/9] perf record: Support synthesizing cgroup events Namhyung Kim
2020-01-08 22:08 ` Jiri Olsa
2020-01-09 5:19 ` Namhyung Kim
2020-01-08 22:18 ` Jiri Olsa
2020-01-09 7:50 ` Namhyung Kim
2020-01-08 22:21 ` Jiri Olsa
2020-01-09 7:51 ` Namhyung Kim
2020-01-07 13:34 ` [PATCH 7/9] perf record: Add --all-cgroups option Namhyung Kim
2020-01-07 13:35 ` [PATCH 8/9] perf top: " Namhyung Kim
2020-01-08 22:24 ` Jiri Olsa [this message]
2020-01-09 7:55 ` Namhyung Kim
2020-01-09 8:18 ` Jiri Olsa
2020-01-07 13:35 ` [PATCH 9/9] perf script: Add --show-cgroup-events option Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2020-03-25 12:45 [PATCHSET 0/9] perf: Improve cgroup profiling (v6) Namhyung Kim
2020-03-25 12:45 ` [PATCH 8/9] perf top: Add --all-cgroups option Namhyung Kim
2020-03-27 16:35 ` Arnaldo Carvalho de Melo
2019-12-23 6:07 [PATCHSET 0/9] perf: Improve cgroup profiling (v3) Namhyung Kim
2019-12-23 6:07 ` [PATCH 8/9] perf top: Add --all-cgroups option Namhyung Kim
2019-12-20 4:32 [PATCHSET 0/9] perf: Improve cgroup profiling (v2) Namhyung Kim
2019-12-20 4:32 ` [PATCH 8/9] perf top: Add --all-cgroups option Namhyung Kim
2019-08-28 7:31 [PATCHSET 0/9] perf: Improve cgroup profiling (v1) Namhyung Kim
2019-08-28 7:31 ` [PATCH 8/9] perf top: Add --all-cgroups option Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108222458.GF12995@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).