linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Yury Norov <yury.norov@gmail.com>,
	linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2 2/2] lib/test_bitmap: Fix address space when test user buffer
Date: Thu, 9 Jan 2020 12:08:14 -0800	[thread overview]
Message-ID: <20200109120814.27198f300bbe209cdc411fc6@linux-foundation.org> (raw)
In-Reply-To: <20200109103601.45929-2-andriy.shevchenko@linux.intel.com>

On Thu,  9 Jan 2020 12:36:01 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Force address space to avoid the following warning:
> 
> lib/test_bitmap.c:461:53: warning: incorrect type in argument 1 (different address spaces)
> lib/test_bitmap.c:461:53:    expected char const [noderef] <asn:1> *ubuf
> lib/test_bitmap.c:461:53:    got char const *in

We did this in

commit 17b6753ff08bc47f50da09f5185849172c598315
Author:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Wed Dec 4 16:53:06 2019 -0800
Commit:     Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Wed Dec 4 19:44:14 2019 -0800

    lib/test_bitmap: force argument of bitmap_parselist_user() to proper address space

> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -458,7 +458,8 @@ static void __init __test_bitmap_parse(int is_user)
>  
>  			set_fs(KERNEL_DS);
>  			time = ktime_get();
> -			err = bitmap_parse_user(test.in, len, bmap, test.nbits);
> +			err = bitmap_parse_user((__force const char __user *)test.in, len,
> +						bmap, test.nbits);
>  			time = ktime_get() - time;
>  			set_fs(orig_fs);
>  		} else {

Except your tree has `test' where mainline has `ptest'.  I'm not sure
what has happened here?


  reply	other threads:[~2020-01-09 20:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09 10:36 [PATCH v2 1/2] lib/test_bitmap: Correct test data offsets for 32-bit Andy Shevchenko
2020-01-09 10:36 ` [PATCH v2 2/2] lib/test_bitmap: Fix address space when test user buffer Andy Shevchenko
2020-01-09 20:08   ` Andrew Morton [this message]
2020-01-09 21:04     ` Andy Shevchenko
2020-01-09 21:52       ` Andrew Morton
2020-01-09 23:00         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200109120814.27198f300bbe209cdc411fc6@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=linux@roeck-us.net \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).