From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jann Horn <jannh@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: "perf ftrace" segfault because ->cpus!=NULL but ->all_cpus==NULL
Date: Thu, 9 Jan 2020 04:59:44 -0800 [thread overview]
Message-ID: <20200109125944.GS15478@tassilo.jf.intel.com> (raw)
In-Reply-To: <20200109122443.GF52936@krava>
> oops, ftrace is using evlist without event ;-) so all_cpus
> will not get initialized..
>
> Andi, should we initialize evlist::all_cpus with the first
> cpus we get, like in the patch below?
I assume perf stat -A still works for all CPUs? If yes it's ok.
-andi
next prev parent reply other threads:[~2020-01-09 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 11:37 "perf ftrace" segfault because ->cpus!=NULL but ->all_cpus==NULL Jann Horn
2020-01-09 12:24 ` Jiri Olsa
2020-01-09 12:59 ` Andi Kleen [this message]
2020-01-09 15:10 ` Arnaldo Carvalho de Melo
2020-01-09 15:12 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109125944.GS15478@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jannh@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).