From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: mchehab@kernel.org, hyun.kwon@xilinx.com, vkoul@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] media: xilinx: Use dma_request_chan() instead dma_request_slave_channel()
Date: Thu, 9 Jan 2020 18:48:47 +0200 [thread overview]
Message-ID: <20200109164847.GF31792@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20191217104235.23771-1-peter.ujfalusi@ti.com>
Hi Peter,
Thank you for the patch.
On Tue, Dec 17, 2019 at 12:42:35PM +0200, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Vinod, could you please pick this up ?
> ---
> drivers/media/platform/xilinx/xilinx-dma.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/xilinx/xilinx-dma.c b/drivers/media/platform/xilinx/xilinx-dma.c
> index b211380a11f2..9ce515ff9c0a 100644
> --- a/drivers/media/platform/xilinx/xilinx-dma.c
> +++ b/drivers/media/platform/xilinx/xilinx-dma.c
> @@ -725,10 +725,10 @@ int xvip_dma_init(struct xvip_composite_device *xdev, struct xvip_dma *dma,
>
> /* ... and the DMA channel. */
> snprintf(name, sizeof(name), "port%u", port);
> - dma->dma = dma_request_slave_channel(dma->xdev->dev, name);
> - if (dma->dma == NULL) {
> + dma->dma = dma_request_chan(dma->xdev->dev, name);
> + if (IS_ERR(dma->dma)) {
> dev_err(dma->xdev->dev, "no VDMA channel found\n");
> - ret = -ENODEV;
> + ret = PTR_ERR(dma->dma);
> goto error;
> }
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-01-09 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 10:42 [PATCH] media: xilinx: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2020-01-09 16:48 ` Laurent Pinchart [this message]
2020-01-09 16:53 ` Laurent Pinchart
2020-01-10 7:06 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109164847.GF31792@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hyun.kwon@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).