From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Rob Herring <robh@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Mark Rutland <mark.rutland@arm.com>, <dmaengine@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH 1/2] dt-bindings: dmaengine: Add UniPhier external DMA controller bindings
Date: Thu, 09 Jan 2020 21:20:43 +0900 [thread overview]
Message-ID: <20200109212043.5800.4A936039@socionext.com> (raw)
In-Reply-To: <20200108035537.GA7843@bogus>
Hi Rob,
Thank you for your comment.
On Tue, 7 Jan 2020 21:55:37 -0600 <robh@kernel.org> wrote:
> On Wed, Dec 18, 2019 at 09:56:59AM +0900, Kunihiko Hayashi wrote:
> > Add external DMA controller bindings implemented in Socionext UniPhier
> > SoCs.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> > ---
> > .../devicetree/bindings/dma/uniphier-xdmac.txt | 86 ++++++++++++++++++++++
> > 1 file changed, 86 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/dma/uniphier-xdmac.txt
>
> Please make this a DT schema. See
> Documentation/devicetree/writing-schema.rst.
Although I'm not familiar with this format, I'll try to make it.
> >
> > diff --git a/Documentation/devicetree/bindings/dma/uniphier-xdmac.txt b/Documentation/devicetree/bindings/dma/uniphier-xdmac.txt
> > new file mode 100644
> > index 00000000..4e3927f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/dma/uniphier-xdmac.txt
> > @@ -0,0 +1,86 @@
> > +Socionext UniPhier external DMA controller bindings
> > +
> > +This describes the devicetree bindings for an external DMA engine to perform
> > +memory-to-memory or peripheral-to-memory data transfer, implemented in
> > +Socionext UniPhier SoCs.
> > +
> > +* DMA controller
> > +
> > +Required properties:
> > +- compatible: Should be "socionext,uniphier-xdmac".
> > +- reg: Specifies offset and length of the register set for the device.
> > +- interrupts: An interrupt specifier associated with the DMA controller.
> > +- #dma-cells: Must be <2>. The first cell represents the channel index.
> > + The second cell represents the factor for transfer request.
> > + This is mentioned in DMA client section.
> > +- dma-channels : Number of DMA channels supported. Should be 16.
>
> If always 16, then why do you need this?
Oh, currently this means 16 or less, though, this is the number supported
by the controller. I'll fix it.
>
> > +
> > +Example:
> > + xdmac: dma-controller@5fc10000 {
> > + compatible = "socionext,uniphier-xdmac";
> > + reg = <0x5fc10000 0x1000>, <0x5fc20000 0x800>;
> > + interrupts = <0 188 4>;
> > + #dma-cells = <2>;
> > + dma-channels = <16>;
> > + };
> > +
> > +* DMA client
> > +
> > +Required properties:
> > +- dmas: A list of DMA channel requests.
> > +- dma-names: Names of the requested channels corresponding to dmas.
> > +
> > +DMA clients must use the format described in the dma.txt file, using a two cell
> > +specifier for each channel.
>
> No need to redefine the client binding here. Just need the cell format
> as below.
I see. I'll replace with the cell format.
Thank you,
---
Best Regards,
Kunihiko Hayashi
next prev parent reply other threads:[~2020-01-09 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 0:56 [PATCH 0/2] dmaengine: Add UniPhier XDMAC driver Kunihiko Hayashi
2019-12-18 0:56 ` [PATCH 1/2] dt-bindings: dmaengine: Add UniPhier external DMA controller bindings Kunihiko Hayashi
2020-01-08 3:55 ` Rob Herring
2020-01-09 12:20 ` Kunihiko Hayashi [this message]
2019-12-18 0:57 ` [PATCH 2/2] dmaengine: uniphier-xdmac: Add UniPhier external DMA controller driver Kunihiko Hayashi
2019-12-27 6:34 ` Vinod Koul
2020-01-09 12:12 ` Kunihiko Hayashi
2020-01-10 8:01 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109212043.5800.4A936039@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masami.hiramatsu@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).