From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Clément Péron" <peron.clem@gmail.com>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: sun4i: Fix inconsistent IS_ERR and PTR_ERR
Date: Fri, 10 Jan 2020 08:18:34 +0100 [thread overview]
Message-ID: <20200110071834.jewrtgqbwrpjdweq@pengutronix.de> (raw)
In-Reply-To: <20200109072735.GA22886@embeddedor>
Hello,
On Thu, Jan 09, 2020 at 01:27:35AM -0600, Gustavo A. R. Silva wrote:
> Fix inconsistent IS_ERR and PTR_ERR in sun4i_pwm_probe().
>
> The proper pointers to be passed as arguments are pwm->clk and pwm->bus_clk.
>
> This bug was detected with the help of Coccinelle.
>
> Fixes: b8d74644f34a ("pwm: sun4i: Prefer "mod" clock to unnamed")
> Fixes: 5b090b430d75 ("pwm: sun4i: Add an optional probe for bus clock")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Patchwork seems to have missed my earlier reply with my Reviewed-by:.
(https://patchwork.ozlabs.org/patch/1220206/ only has Clément's reply
that still contains my quoted text, but obviously this wasn't picked up
by patchwork.)
So resending it in the hope this was a one-time miss:
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
prev parent reply other threads:[~2020-01-10 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 7:27 [PATCH] pwm: sun4i: Fix inconsistent IS_ERR and PTR_ERR Gustavo A. R. Silva
2020-01-09 7:44 ` Uwe Kleine-König
2020-01-09 9:14 ` Clément Péron
2020-01-09 13:18 ` Uwe Kleine-König
2020-01-10 7:18 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110071834.jewrtgqbwrpjdweq@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=gustavo@embeddedor.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=peron.clem@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).