From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Chuanhong Guo <gch981213@gmail.com>,
linux-mtd@lists.infradead.org,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mtd: nand: spi: rework detect procedure for different read id op
Date: Fri, 10 Jan 2020 09:21:52 +0100 [thread overview]
Message-ID: <20200110092152.64d05705@collabora.com> (raw)
In-Reply-To: <20200110091024.56918193@xps13>
On Fri, 10 Jan 2020 09:10:24 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Boris,
>
> Boris Brezillon <boris.brezillon@collabora.com> wrote on Fri, 10 Jan
> 2020 09:04:22 +0100:
>
> > On Fri, 10 Jan 2020 15:34:28 +0800
> > Chuanhong Guo <gch981213@gmail.com> wrote:
> >
> > > Hi!
> > >
> > > On Fri, Jan 10, 2020 at 2:59 PM Boris Brezillon
> > > <boris.brezillon@collabora.com> wrote:
> > > > [...]
> > > > > + ret = spinand_read_id_op(spinand, 1, 0, id);
> > > > > + if (ret)
> > > > > + return ret;
> > > > > + ret = spinand_manufacturer_match(spinand,
> > > > > + SPINAND_READID_METHOD_OPCODE_ADDR);
> > > > > + if (!ret)
> > > > > + return 0;
> > > > > +
> > > > > + ret = spinand_read_id_op(spinand, 0, 1, id);
> > > >
> > > > Hm, we should probably do only one of each read_id and iterate over all
> > > > manufacturers/chips each time instead of doing 3 read_ids per
> > > > manufacturer.
> > >
> > > This actually do the former instead of the latter. Maybe the function
> > > names are a bit
> > > misleading. spinand_manufacturer_match iterates over all manufacturers
> > > in one call,
> > > and spinand_manufacturer_detect is called once in spinand_detect.
> > > Do you have suggestions on function naming?
> >
> > Maybe you can just inline the content of this function in
> > spinand_detect().
>
> Actually I found that part clear enough, I would keep it as is, out of
> the spinand_detect() function as long as there is no actual reason to
> merge them?
Hm, I kind of disagree. The current name makes it sound like the
function detects the manufacturer or does a per-manufacturer id
detection, which is not the case. How about spinand_id_based_detect() or
spinand_readid_detect()?
prev parent reply other threads:[~2020-01-10 8:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 2:51 [PATCH v2] mtd: nand: spi: rework detect procedure for different read id op Chuanhong Guo
2020-01-10 6:58 ` Boris Brezillon
2020-01-10 7:34 ` Chuanhong Guo
2020-01-10 8:04 ` Boris Brezillon
2020-01-10 8:10 ` Miquel Raynal
2020-01-10 8:21 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110092152.64d05705@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=gch981213@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).