From: Peter Zijlstra <peterz@infradead.org>
To: Qais Yousef <qais.yousef@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
valentin.schneider@arm.com, qperret@google.com,
Patrick Bellasi <patrick.bellasi@matbug.net>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] sched/rt: Add a new sysctl to control uclamp_util_min
Date: Fri, 10 Jan 2020 14:39:56 +0100 [thread overview]
Message-ID: <20200110133956.GL2844@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200109130052.feebuwuuvwvm324w@e107158-lin.cambridge.arm.com>
On Thu, Jan 09, 2020 at 01:00:58PM +0000, Qais Yousef wrote:
> On 01/08/20 14:44, Peter Zijlstra wrote:
> > On Fri, Dec 20, 2019 at 04:48:38PM +0000, Qais Yousef wrote:
> > > RT tasks by default try to run at the highest capacity/performance
> > > level. When uclamp is selected this default behavior is retained by
> > > enforcing the uclamp_util_min of the RT tasks to be
> > > uclamp_none(UCLAMP_MAX), which is SCHED_CAPACITY_SCALE; the maximum
> > > value.
> > >
> > > See commit 1a00d999971c ("sched/uclamp: Set default clamps for RT tasks").
> > >
> > > On battery powered devices, this default behavior could consume more
> > > power, and it is desired to be able to tune it down. While uclamp allows
> > > tuning this by changing the uclamp_util_min of the individual tasks, but
> > > this is cumbersome and error prone.
> > >
> > > To control the default behavior globally by system admins and device
> > > integrators, introduce the new sysctl_sched_rt_uclamp_util_min to
> > > change the default uclamp_util_min value of the RT tasks.
> > >
> > > Whenever the new default changes, it'd be applied on the next wakeup of
> > > the RT task, assuming that it still uses the system default value and
> > > not a user applied one.
> >
> > This is because these RT tasks are not in a cgroup or not affected by
> > cgroup settings? I feel the justification is a little thin here.
>
> The uclamp_min for RT tasks is always hardcoded to 1024 at the moment. So even
> if they belong to a cgroup->uclamp_min = 0, they'll still run at max frequency,
> no?
Argh, this is that counter intuitive max aggregate nonsense biting me.
next prev parent reply other threads:[~2020-01-10 13:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 16:48 [PATCH] sched/rt: Add a new sysctl to control uclamp_util_min Qais Yousef
2020-01-07 13:42 ` Quentin Perret
2020-01-07 19:30 ` Dietmar Eggemann
2020-01-08 9:51 ` Quentin Perret
2020-01-08 19:16 ` Patrick Bellasi
2020-01-09 11:36 ` Qais Yousef
2020-01-09 11:16 ` Qais Yousef
2020-01-09 11:12 ` Qais Yousef
2020-01-08 13:44 ` Peter Zijlstra
2020-01-08 19:08 ` Patrick Bellasi
2020-01-09 13:00 ` Qais Yousef
2020-01-10 13:39 ` Peter Zijlstra [this message]
2020-01-12 23:35 ` Qais Yousef
2020-01-10 13:42 ` Peter Zijlstra
2020-01-12 23:31 ` Qais Yousef
2020-01-08 18:56 ` Patrick Bellasi
2020-01-09 1:35 ` Valentin Schneider
2020-01-09 9:21 ` Patrick Bellasi
2020-01-09 13:38 ` Qais Yousef
2020-01-14 21:34 ` Qais Yousef
2020-01-22 10:19 ` Patrick Bellasi
2020-01-22 11:45 ` Qais Yousef
2020-01-22 12:44 ` Patrick Bellasi
2020-01-22 14:57 ` Qais Yousef
2020-01-09 13:15 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110133956.GL2844@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@matbug.net \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).