linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: Anders Roxell <anders.roxell@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Jan 10
Date: Fri, 10 Jan 2020 13:52:38 +0000	[thread overview]
Message-ID: <20200110135238.GA9315@arm.com> (raw)
In-Reply-To: <CADYN=9+VoYekNzsdrL+bnb3oB9Y4guE3o2okwiBD4J-c_=kAyg@mail.gmail.com>

On Fri, Jan 10, 2020 at 10:11:41AM +0000, Anders Roxell wrote:
> On Fri, 10 Jan 2020 at 09:07, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > Changes since 20200109:
> 
> I see the following build error on arm64:
> 
> ../arch/arm64/mm/dump.c: In function ‘ptdump_walk’:
> ../arch/arm64/mm/dump.c:326:2: error: too few arguments to function
> ‘ptdump_walk_pgd’
>   ptdump_walk_pgd(&st.ptdump, info->mm);
>   ^~~~~~~~~~~~~~~
> In file included from ../arch/arm64/mm/dump.c:18:
> ../include/linux/ptdump.h:20:6: note: declared here
>  void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> pgd_t *pgd);
>       ^~~~~~~~~~~~~~~
> ../arch/arm64/mm/dump.c: In function ‘ptdump_check_wx’:
> ../arch/arm64/mm/dump.c:364:2: error: too few arguments to function
> ‘ptdump_walk_pgd’
>   ptdump_walk_pgd(&st.ptdump, &init_mm);
>   ^~~~~~~~~~~~~~~
> In file included from ../arch/arm64/mm/dump.c:18:
> ../include/linux/ptdump.h:20:6: note: declared here
>  void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> pgd_t *pgd);
>       ^~~~~~~~~~~~~~~
> make[3]: *** [../scripts/Makefile.build:266: arch/arm64/mm/dump.o] Error 1
> make[3]: Target '__build' not remade because of errors.
> make[2]: *** [../scripts/Makefile.build:503: arch/arm64/mm] Error 2
> make[2]: Target '__build' not remade because of errors.
> make[1]: *** [/srv/jenkins/kernel/randconfig/Makefile:1683: arch/arm64] Error 2
> 
> I think something happened when applying patch [1], the changes in
> arch/arm64/mm/dump.c
> got dropped somehow. What that intended ?
> 

Indeed this chunk appears to be missing in Andrew's version of the
patch[1] too. Clearly the interface change needs to be included in the
arm64 code. Perhaps the "x86" tag in the subject caused confusion?

Steve

[1] https://ozlabs.org/~akpm/mmots/broken-out/x86-mm-avoid-allocating-struct-mm_struct-on-the-stack.patch

> 
> Cheers,
> Anders
> [1] https://lore.kernel.org/lkml/20200108145710.34314-1-steven.price@arm.com/

  reply	other threads:[~2020-01-10 13:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  8:07 linux-next: Tree for Jan 10 Stephen Rothwell
2020-01-10 10:11 ` Anders Roxell
2020-01-10 13:52   ` Steven Price [this message]
2020-01-10 16:09 ` linux-next: Tree for Jan 10 (amdgpu) Randy Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2024-01-10  5:32 linux-next: Tree for Jan 10 Stephen Rothwell
2023-01-10  3:09 Stephen Rothwell
2022-01-10  8:48 Stephen Rothwell
2019-01-10  4:14 Stephen Rothwell
2018-01-10  5:24 Stephen Rothwell
2017-01-10  3:58 Stephen Rothwell
2014-01-10  5:12 Stephen Rothwell
2013-01-10  3:32 Stephen Rothwell
2012-01-10  5:44 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200110135238.GA9315@arm.com \
    --to=steven.price@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=anders.roxell@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).