From: kbuild test robot <lkp@intel.com>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: kbuild-all@lists.01.org, mingo@redhat.com, peterz@infradead.org,
ionela.voinescu@arm.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rui.zhang@intel.com,
qperret@google.com, daniel.lezcano@linaro.org,
viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
amit.kachhap@gmail.com, javi.merino@kernel.org,
amit.kucheria@verdurent.com
Subject: Re: [Patch v7 4/7] sched/fair: Enable periodic update of average thermal pressure
Date: Sun, 12 Jan 2020 13:43:02 +0800 [thread overview]
Message-ID: <202001121348.oYbpNB8y%lkp@intel.com> (raw)
In-Reply-To: <1578758346-507-5-git-send-email-thara.gopinath@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2745 bytes --]
Hi Thara,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20200110]
[also build test ERROR on v5.5-rc5]
[cannot apply to tip/sched/core tip/perf/core arm/for-next arm64/for-next/core driver-core/driver-core-testing linus/master v5.5-rc5 v5.5-rc4 v5.5-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Thara-Gopinath/Introduce-Thermal-Pressure/20200112-000559
base: 6c09d7dbb7d366122d0218bc7487e0a1e6cca6ed
config: mips-fuloong2e_defconfig (attached as .config)
compiler: mips64el-linux-gcc (GCC) 5.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=5.5.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/sched/fair.c: In function 'task_tick_fair':
>> kernel/sched/fair.c:10308:2: error: implicit declaration of function 'update_thermal_load_avg' [-Werror=implicit-function-declaration]
update_thermal_load_avg(rq_clock_task(rq), rq, thermal_pressure);
^
cc1: some warnings being treated as errors
vim +/update_thermal_load_avg +10308 kernel/sched/fair.c
10283
10284 /*
10285 * scheduler tick hitting a task of our scheduling class.
10286 *
10287 * NOTE: This function can be called remotely by the tick offload that
10288 * goes along full dynticks. Therefore no local assumption can be made
10289 * and everything must be accessed through the @rq and @curr passed in
10290 * parameters.
10291 */
10292 static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
10293 {
10294 struct cfs_rq *cfs_rq;
10295 struct sched_entity *se = &curr->se;
10296 unsigned long thermal_pressure = arch_cpu_thermal_pressure(cpu_of(rq));
10297
10298 for_each_sched_entity(se) {
10299 cfs_rq = cfs_rq_of(se);
10300 entity_tick(cfs_rq, se, queued);
10301 }
10302
10303 if (static_branch_unlikely(&sched_numa_balancing))
10304 task_tick_numa(rq, curr);
10305
10306 update_misfit_status(curr, rq);
10307 update_overutilized_status(task_rq(curr));
10308 update_thermal_load_avg(rq_clock_task(rq), rq, thermal_pressure);
10309 }
10310
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19181 bytes --]
next prev parent reply other threads:[~2020-01-12 6:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 15:58 [Patch v7 0/7] Introduce Thermal Pressure Thara Gopinath
2020-01-11 15:59 ` [Patch v7 1/7] sched/pelt: Add support to track thermal pressure Thara Gopinath
2020-01-11 15:59 ` [Patch v7 2/7] sched/topology: Add hook to read per cpu " Thara Gopinath
2020-01-11 15:59 ` [Patch v7 3/7] arm,arm64,drivers:Add infrastructure to store and update instantaneous " Thara Gopinath
2020-01-11 15:59 ` [Patch v7 4/7] sched/fair: Enable periodic update of average " Thara Gopinath
2020-01-11 18:27 ` kbuild test robot
2020-01-12 5:43 ` kbuild test robot [this message]
2020-01-11 15:59 ` [Patch v7 5/7] sched/fair: update cpu_capacity to reflect " Thara Gopinath
2020-01-11 15:59 ` [Patch v7 6/7] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2020-01-11 15:59 ` [Patch v7 7/7] sched/fair: Enable tuning of decay period Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001121348.oYbpNB8y%lkp@intel.com \
--to=lkp@intel.com \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).