From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB31C33CAB for ; Mon, 13 Jan 2020 09:44:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0241F2084D for ; Mon, 13 Jan 2020 09:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578908642; bh=UtHfmZbsNcplNP3k+bEt4c2k9o181tnaCpLdxVZFFQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ynn0h7IlAVSS+k/0uZ6V2mzOxqiRa4Wxv9cBilx87kBOIDTHeiOOOSQfJ4347aBPm l7luMctDBpk3CyZnF25edxdS/mJcJLFOK9OMn44gAT8SWIvBAyWUTZpaeLeJasD4jr 5dKj2X8Mk44noFOjagu+yFfpvVcphygLGQBAwMtY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728643AbgAMJoB (ORCPT ); Mon, 13 Jan 2020 04:44:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:59158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgAMJoB (ORCPT ); Mon, 13 Jan 2020 04:44:01 -0500 Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 10BF82075B; Mon, 13 Jan 2020 09:43:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578908640; bh=UtHfmZbsNcplNP3k+bEt4c2k9o181tnaCpLdxVZFFQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Chqov/hf8tR7oy+LK2yRjMCtLFz+wPmkrkH0qv6ptZ93DU/La0cx0HYm1cohXJsSc kgcX/e9UlSQAUk6fWS5TSErd/fDzcDnG+oT58Jx636C92DgH56LFKSjJWk5s7Djmkd hSW/oqvXZ/oAFkr6VUIml5NMHscjdN8PYHy7QV1U= Date: Mon, 13 Jan 2020 10:43:58 +0100 From: Maxime Ripard To: Samuel Holland Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Mark Rutland , Chen-Yu Tsai , Russell King , Catalin Marinas , Will Deacon , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 3/9] dt-bindings: irq: Add a compatible for the H3 R_INTC Message-ID: <20200113094358.7jefihp4i4rt4orm@gilmour.lan> References: <20200113044936.26038-1-samuel@sholland.org> <20200113044936.26038-4-samuel@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="smzsasjwaytwgncj" Content-Disposition: inline In-Reply-To: <20200113044936.26038-4-samuel@sholland.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --smzsasjwaytwgncj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 12, 2020 at 10:49:30PM -0600, Samuel Holland wrote: > The Allwinner H3 SoC contains an R_INTC that is, as far as we know, > compatible with the R_INTC present in other sun8i/sun50i SoCs starting > with the A31. Since the R_INTC hardware is undocumented, introduce a new > compatible for the R_INTC variant in this SoC, in case there turns out > to be some difference. > > Signed-off-by: Samuel Holland > --- > .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml > index 0eccf5551786..fffffcd0eea3 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml > @@ -29,6 +29,9 @@ properties: > - items: > - const: allwinner,sun8i-a83t-r-intc > - const: allwinner,sun6i-a31-r-intc > + - items: > + - const: allwinner,sun8i-h3-r-intc > + - const: allwinner,sun6i-a31-r-intc If we are to add more compatibles, I guess we could switch to something like: items: - enum: - allwinner,sun8i-a83t-r-intc - allwinner,sun8i-h3-r-intc - const: allwinner,sun6i-a31-r-intc It's going to be easier to maintain in the long run. Thanks! Maxime --smzsasjwaytwgncj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXhw73gAKCRDj7w1vZxhR xfhpAQDaJubC92ncM6GPUUqzW3nc++GjfRAhdInV8usAwqdmxwD+P5/2e/W5eeaW kJxLxEHrY7QaX68C60fWL9XuCd6QbAc= =lixO -----END PGP SIGNATURE----- --smzsasjwaytwgncj--