From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA19AC33CAD for ; Mon, 13 Jan 2020 11:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D19F2081E for ; Mon, 13 Jan 2020 11:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578915801; bh=g2n49SGBTNUtqISjbMsN587xlnonpg3/x81aMuFYk+w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AwVHnJSUS+BdLxvN3bxFlhAPuT+k5kkKmbkTv11iKIyxzzlD8vAw5L8VSDZSK8LaO mMI8pZgU7urvH1u4IRObBDtiPc1rQmIut6EHX0eZyQPCgxi30wiBaiT4tGVe7GhUf8 Q989Omk+lRIIud4ic/nt3a36WfnpTI5ZNSAgLwfY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728640AbgAMLnU (ORCPT ); Mon, 13 Jan 2020 06:43:20 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:49584 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbgAMLnU (ORCPT ); Mon, 13 Jan 2020 06:43:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=g2n49SGBTNUtqISjbMsN587xlnonpg3/x81aMuFYk+w=; b=GTD5rauEfghSV4/oUex1iEqWr bX8wCRdUTchQ9oIAMcrz4sIGn3JnxNCtq+wW60KqPFqZSICTwL3tIrQ7F6KujZQnv/KIr+dTFxgEx 2RnydC2JGjuxtyhPcvTjXyDaBRFVz9nAE/nUW1P3drRG5QBr2MLXfRghZC11aZPsOJUs8=; Received: from fw-tnat-cam7.arm.com ([217.140.106.55] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iqy7V-0001fp-Lj; Mon, 13 Jan 2020 11:42:57 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id EF79BD00AD6; Mon, 13 Jan 2020 11:42:56 +0000 (GMT) Date: Mon, 13 Jan 2020 11:42:56 +0000 From: Mark Brown To: John Garry Cc: Andy Shevchenko , tudor.ambarus@microchip.com, linux-kernel@vger.kernel.org, chenxiang66@hisilicon.com, linuxarm@huawei.com, linux-spi@vger.kernel.org, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, xuejiancheng@hisilicon.com, fengsheng5@huawei.com, Mika Westerberg , wanghuiqiang , liusimin4@huawei.com Subject: Re: [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver Message-ID: <20200113114256.GH3897@sirena.org.uk> References: <1575900490-74467-1-git-send-email-john.garry@huawei.com> <1575900490-74467-3-git-send-email-john.garry@huawei.com> <0dc5cb2e-b765-9e13-b05e-9e3c835c5985@huawei.com> <20200109212842.GK3702@sirena.org.uk> <20200110140726.GB5889@sirena.org.uk> <6db83881-927c-d11c-9c77-23a45892ddab@huawei.com> <20200110193119.GI32742@smile.fi.intel.com> <612a3c5d-69a4-af6b-5c79-c3fb853193ab@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="X+8siUETKMkW99st" Content-Disposition: inline In-Reply-To: <612a3c5d-69a4-af6b-5c79-c3fb853193ab@huawei.com> X-Cookie: Programming is an unnatural act. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --X+8siUETKMkW99st Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 13, 2020 at 10:09:27AM +0000, John Garry wrote: > On 10/01/2020 19:31, Andy Shevchenko wrote: > > PRP method is only for vendors to *test* the hardware in ACPI environment. > > The proper method is to allocate correct ACPI ID. > Yes, that would seem the proper thing to do. So the SPI NOR driver is based > on micron m25p80 and compatible string is "jedec,spi-nor", so I don't know > who should or would do this registration. The idiomatic approach appears to be for individual board vendors to allocate IDs, you do end up with multiple IDs from multiple vendors for the same thing. > BTW, Do any of these sensors you mention have any ACPI standardization? In general there's not really much standardizaiton for devices, the bindings that do exist aren't really centrally documented and the Windows standard is just to have the basic device registration in the firmware and do all properties based on quirking based on DMI information. --X+8siUETKMkW99st Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4cV8AACgkQJNaLcl1U h9C/cAf/f3KqQoM3kgbWl0MgRMi2T0mY02dvLgcINSfWU08s8WPRzo3zWZ+2Bnwy EtoOy7yu9z4hC9RVNYaA3/FibeE10MJHizzwRnxzzxmu3MjPDixmON8GO+hsKPd6 DYhpptH+23ceLUX3O7l8v34vvslFYKaUeSJkTlCR0OxxEkTCxwnWnWo/wKBYTRer T58Cj6e/WnAl2qZ4Yl4qJF2TpNTC7T5tHki/I72eEZfiaNylIKxERV27zddbrgHE dyOKFqftALoJvu2cf/ddKpXKNt1ceMDNGhu3bIBJuoSdYAedtvWRs9TPRigY5bvZ IiypAujroXyiqSqmQq+3FBBNH9tTXw== =w5W/ -----END PGP SIGNATURE----- --X+8siUETKMkW99st--