* [PATCH] amd-xgbe: remove unnecessary conversion to bool
@ 2020-01-13 13:15 Chen Zhou
2020-01-14 2:23 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2020-01-13 13:15 UTC (permalink / raw)
To: thomas.lendacky, davem; +Cc: netdev, linux-kernel, chenzhou10
The conversion to bool is not needed, remove it.
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
index 128cd64..46c3c1c 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
@@ -1227,7 +1227,7 @@ static bool xgbe_phy_sfp_verify_eeprom(u8 cc_in, u8 *buf, unsigned int len)
for (cc = 0; len; buf++, len--)
cc += *buf;
- return (cc == cc_in) ? true : false;
+ return cc == cc_in;
}
static int xgbe_phy_sfp_read_eeprom(struct xgbe_prv_data *pdata)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] amd-xgbe: remove unnecessary conversion to bool
2020-01-13 13:15 [PATCH] amd-xgbe: remove unnecessary conversion to bool Chen Zhou
@ 2020-01-14 2:23 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-01-14 2:23 UTC (permalink / raw)
To: Chen Zhou; +Cc: thomas.lendacky, davem, netdev, linux-kernel
On Mon, 13 Jan 2020 21:15:16 +0800, Chen Zhou wrote:
> The conversion to bool is not needed, remove it.
>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Applied to net-next, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-14 2:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 13:15 [PATCH] amd-xgbe: remove unnecessary conversion to bool Chen Zhou
2020-01-14 2:23 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).