From: Rob Herring <robh@kernel.org>
To: Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: maz@kernel.org, jason@lakedaemon.net, tglx@linutronix.de,
mark.rutland@arm.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-imx@nxp.com, fugang.duan@nxp.com
Subject: Re: [PATCH V4 RESEND 1/2] dt-bindings/irq: add binding for NXP INTMUX interrupt multiplexer
Date: Mon, 13 Jan 2020 15:03:44 -0600 [thread overview]
Message-ID: <20200113210344.GA4615@bogus> (raw)
In-Reply-To: <1578899321-1365-2-git-send-email-qiangqing.zhang@nxp.com>
On Mon, Jan 13, 2020 at 03:08:40PM +0800, Joakim Zhang wrote:
> This patch adds the DT bindings for the NXP INTMUX interrupt multiplexer
> for i.MX8 family SoCs.
>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> ---
> .../interrupt-controller/fsl,intmux.yaml | 77 +++++++++++++++++++
> 1 file changed, 77 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
Please run 'make dt_binding_check' and fix the errors:
Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml:
while scanning for the next token found character that cannot start any token
in "<unicode string>", line 60, column 1
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
> new file mode 100644
> index 000000000000..4dba532fe0bd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/fsl,intmux.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale INTMUX interrupt multiplexer
> +
> +maintainers:
> + - Marc Zyngier <maz@kernel.org>
> +
> +properties:
> + compatible:
> + items:
> + const: fsl,imx-intmux
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + minItems: 1
> + maxItems: 8
> + description: |
> + Should contain the parent interrupt lines (up to 8) used to multiplex
> + the input interrupts.
> +
> + interrupt-controller: true
> +
> + '#interrupt-cells':
> + const: 2
> +
> + clocks:
> + maxItems: 1
> + description: ipg clock.
> +
> + clock-names:
> + items:
> + const: ipg
> +
> + fsl,intmux_chans:
Don't use '_' in property names.
Is this any different from the length of 'interrupts' which you can
count?
> + maxItems: 1
> + description: |
> + The number of channels used for interrupt source. The Maximum value is 8.
> + If this property is not set in DT then driver uses 1 channel by default.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-controller
> + - '#interrupt-cells'
> + - clocks
> + - clock-name
> + - fsl,intmux_chans
> +
> +additionalProperties: false
> +
> +Example:
> +
> + intmux@37400000 {
interrupt-controller@...
> + compatible = "fsl,imx-intmux";
> + reg = <0x37400000 0x1000>;
> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + clocks = <&clk IMX8QM_CM40_IPG_CLK>;
> + clock-names = "ipg";
> + fsl,intmux_chans = <8>;
> + };
> +
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-01-13 21:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 7:08 [PATCH V4 RESEND 0/2] irqchip: add NXP INTMUX interrupt controller Joakim Zhang
2020-01-13 7:08 ` [PATCH V4 RESEND 1/2] dt-bindings/irq: add binding for NXP INTMUX interrupt multiplexer Joakim Zhang
2020-01-13 9:16 ` Marc Zyngier
2020-01-13 9:59 ` Joakim Zhang
2020-01-13 21:03 ` Rob Herring [this message]
2020-01-14 2:43 ` Joakim Zhang
2020-01-14 8:22 ` Joakim Zhang
2020-01-14 14:11 ` Rob Herring
2020-01-15 2:27 ` Joakim Zhang
2020-01-13 7:08 ` [PATCH V4 RESEND 2/2] drivers/irqchip: add NXP INTMUX interrupt multiplexer support Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113210344.GA4615@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=jason@lakedaemon.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).