From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9290CC33CA9 for ; Mon, 13 Jan 2020 23:14:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E13F206DA for ; Mon, 13 Jan 2020 23:14:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nAGHf/Ep" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729213AbgAMXOR (ORCPT ); Mon, 13 Jan 2020 18:14:17 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:34699 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728794AbgAMXOR (ORCPT ); Mon, 13 Jan 2020 18:14:17 -0500 Received: by mail-ot1-f65.google.com with SMTP id a15so10730057otf.1; Mon, 13 Jan 2020 15:14:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UsZ98rCI7PkotKyjeTY7iS3Bvm6JfyKWnW/whK0DyZg=; b=nAGHf/Epi8EvVV6HKtc8h4VOKLsZX2aCiLzTruVWJDs3wKYW1pfb4zmIMlWSj/HpKL x12yC6aY8Co2Br7xxa1pfKib+BxaDxPSqjVZv7jTi5EJHNpfnsejd/8ftdx1e2yhh7lh fAhYZVAF/Ga15a5nY5O6wEAgbS/s9PIsmoUOMR49xmNMrjFyYNKNnyYEFSPpHzYwTrYV aZJ+YufrTK1dxpg/UmB5jRVVMRXl1D/QXUsGGZWIwbyvcX2KcAZNXLOWf7VJPTE1CqMz pnJcqE57t32IXh4SyELJt0q/inz8d7w4jxqN1vAT+IBHKFgCH5aRyFxxtuKBwG32NNqs 71Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UsZ98rCI7PkotKyjeTY7iS3Bvm6JfyKWnW/whK0DyZg=; b=SA+k4BOISIkFJroXsiVJsb2eGaBD1vRrym/BYtyI8kD77Qa6tifCLONpBuTKy9h7+X Ca3c/+uODDLpXEWwmiRFoyT+fyjVvvi3JB6IjoER7cmZcXpZg6RJL/NGtxqpv1kJIupn PiOLI2Jqc1u4e+W+YRCdYqs2Ht5gTfHWPEAua401finuFuCOtNQOnZFu6DePqCvgBm9J i62CQ7A6Ovzp6AQ5GyGxTrR7GwAEr142JmwjkdC3ZkNDt1M/C7GzmNqg0revBnru2egY cTlyPQ9/kD8pFfA6fJKSpWiMAkLEO4qEhs6lKXgEHTFm8pISZbRSTV9mo9/22fqWKnnA MJlw== X-Gm-Message-State: APjAAAVlFEFNEXSpPM/VHoKAKmkyZUB411XbcWJL70+6WOFh8jKdEUTC kyNC1CxR1TpKcYC1kK4M+z8= X-Google-Smtp-Source: APXvYqw1JmIvG6iWu6vPIbvwsWVsMZVyfmrNUDYwfcGB4Ecsie8cdsFDuVCZyrXwgkrK/dKTz2ct2w== X-Received: by 2002:a9d:c02:: with SMTP id 2mr15137769otr.183.1578957255384; Mon, 13 Jan 2020 15:14:15 -0800 (PST) Received: from ubuntu-x2-xlarge-x86 ([2604:1380:4111:8b00::1]) by smtp.gmail.com with ESMTPSA id j10sm4680785otr.64.2020.01.13.15.14.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Jan 2020 15:14:14 -0800 (PST) Date: Mon, 13 Jan 2020 16:14:13 -0700 From: Nathan Chancellor To: "Gustavo A. R. Silva" Cc: Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Dmitry Vyukov , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] media: i2c: adv748x: Fix unsafe macros Message-ID: <20200113231413.GA23583@ubuntu-x2-xlarge-x86> References: <20191022132522.GA12072@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191022132522.GA12072@embeddedor> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 22, 2019 at 08:25:22AM -0500, Gustavo A. R. Silva wrote: > Enclose multiple macro parameters in parentheses in order to > make such macros safer and fix the Clang warning below: > > drivers/media/i2c/adv748x/adv748x-afe.c:452:12: warning: operator '?:' > has lower precedence than '|'; '|' will be evaluated first > [-Wbitwise-conditional-parentheses] > > ret = sdp_clrset(state, ADV748X_SDP_FRP, ADV748X_SDP_FRP_MASK, enable > ? ctrl->val - 1 : 0); > > Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver") > Reported-by: Dmitry Vyukov > Signed-off-by: Gustavo A. R. Silva > --- > drivers/media/i2c/adv748x/adv748x.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x.h b/drivers/media/i2c/adv748x/adv748x.h > index 5042f9e94aee..fccb388ce179 100644 > --- a/drivers/media/i2c/adv748x/adv748x.h > +++ b/drivers/media/i2c/adv748x/adv748x.h > @@ -394,10 +394,10 @@ int adv748x_write_block(struct adv748x_state *state, int client_page, > > #define io_read(s, r) adv748x_read(s, ADV748X_PAGE_IO, r) > #define io_write(s, r, v) adv748x_write(s, ADV748X_PAGE_IO, r, v) > -#define io_clrset(s, r, m, v) io_write(s, r, (io_read(s, r) & ~m) | v) > +#define io_clrset(s, r, m, v) io_write(s, r, (io_read(s, r) & ~(m)) | (v)) > > #define hdmi_read(s, r) adv748x_read(s, ADV748X_PAGE_HDMI, r) > -#define hdmi_read16(s, r, m) (((hdmi_read(s, r) << 8) | hdmi_read(s, r+1)) & m) > +#define hdmi_read16(s, r, m) (((hdmi_read(s, r) << 8) | hdmi_read(s, (r)+1)) & (m)) > #define hdmi_write(s, r, v) adv748x_write(s, ADV748X_PAGE_HDMI, r, v) > > #define repeater_read(s, r) adv748x_read(s, ADV748X_PAGE_REPEATER, r) > @@ -405,11 +405,11 @@ int adv748x_write_block(struct adv748x_state *state, int client_page, > > #define sdp_read(s, r) adv748x_read(s, ADV748X_PAGE_SDP, r) > #define sdp_write(s, r, v) adv748x_write(s, ADV748X_PAGE_SDP, r, v) > -#define sdp_clrset(s, r, m, v) sdp_write(s, r, (sdp_read(s, r) & ~m) | v) > +#define sdp_clrset(s, r, m, v) sdp_write(s, r, (sdp_read(s, r) & ~(m)) | (v)) > > #define cp_read(s, r) adv748x_read(s, ADV748X_PAGE_CP, r) > #define cp_write(s, r, v) adv748x_write(s, ADV748X_PAGE_CP, r, v) > -#define cp_clrset(s, r, m, v) cp_write(s, r, (cp_read(s, r) & ~m) | v) > +#define cp_clrset(s, r, m, v) cp_write(s, r, (cp_read(s, r) & ~(m)) | (v)) > > #define tx_read(t, r) adv748x_read(t->state, t->page, r) > #define tx_write(t, r, v) adv748x_write(t->state, t->page, r, v) > -- > 2.23.0 >