From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jean Delvare <khali@linux-fr.org>, Daniel Kurtz <djkurtz@chromium.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot <syzbot+ed71512d469895b5b34e@syzkaller.appspotmail.com>
Subject: [PATCH] i2c: i801: Fix memory corruption in i801_isr_byte_done()
Date: Tue, 14 Jan 2020 10:34:06 +0300 [thread overview]
Message-ID: <20200114073406.qaq3hbrhtx76fkes@kili.mountain> (raw)
In-Reply-To: <0000000000009586b2059c13c7e1@google.com>
Assigning "priv->data[-1] = priv->len;" obviously doesn't make sense.
What it does is it ends up corrupting the last byte of priv->len so
priv->len becomes a very high number.
Reported-by: syzbot+ed71512d469895b5b34e@syzkaller.appspotmail.com
Fixes: d3ff6ce40031 ("i2c-i801: Enable IRQ for byte_by_byte transactions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Untested.
drivers/i2c/busses/i2c-i801.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index f5e69fe56532..420d8025901e 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -584,7 +584,6 @@ static void i801_isr_byte_done(struct i801_priv *priv)
"SMBus block read size is %d\n",
priv->len);
}
- priv->data[-1] = priv->len;
}
/* Read next byte */
--
2.11.0
next prev parent reply other threads:[~2020-01-14 7:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 6:34 KASAN: vmalloc-out-of-bounds Write in i801_isr syzbot
2020-01-14 7:34 ` Dan Carpenter [this message]
2020-02-22 12:45 ` [PATCH] i2c: i801: Fix memory corruption in i801_isr_byte_done() Wolfram Sang
2020-03-20 14:57 ` Wolfram Sang
2020-03-22 18:08 ` Jean Delvare
2020-03-22 21:10 ` Andy Shevchenko
2020-03-22 21:12 ` Wolfram Sang
2020-03-22 22:11 ` Jean Delvare
2020-03-23 9:37 ` Dan Carpenter
2020-03-23 17:51 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114073406.qaq3hbrhtx76fkes@kili.mountain \
--to=dan.carpenter@oracle.com \
--cc=djkurtz@chromium.org \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+ed71512d469895b5b34e@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).