From: kbuild test robot <lkp@intel.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
cphealy@gmail.com, rmk+kernel@armlinux.org.uk, kuba@kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: Maintain MDIO device and bus statistics
Date: Tue, 14 Jan 2020 12:44:42 +0800 [thread overview]
Message-ID: <202001141253.BsdyxzQs%lkp@intel.com> (raw)
In-Reply-To: <20200113045325.13470-1-f.fainelli@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3979 bytes --]
Hi Florian,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master ipvs/master v5.5-rc6 next-20200110]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-phy-Maintain-MDIO-device-and-bus-statistics/20200113-125529
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5c9166f038257d6130865b267cb45d87f126b3dd
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
drivers/net/phy/mdio_bus.c: In function 'mdio_bus_stats_transfers_show':
drivers/net/phy/mdio_bus.c:305:32: error: pasting ""%llu"" and ""\n"" does not give a valid preprocessing token
MDIO_BUS_STATS_SHOW(transfers, "%llu");
^
drivers/net/phy/mdio_bus.c:296:21: note: in definition of macro 'MDIO_BUS_STATS_SHOW_NAME'
len = sprintf(buf, format_string ## "\n", tmp); \
^~~~~~~~~~~~~
>> drivers/net/phy/mdio_bus.c:305:1: note: in expansion of macro 'MDIO_BUS_STATS_SHOW'
MDIO_BUS_STATS_SHOW(transfers, "%llu");
^~~~~~~~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c: In function 'mdio_bus_stats_errors_show':
drivers/net/phy/mdio_bus.c:306:29: error: pasting ""%llu"" and ""\n"" does not give a valid preprocessing token
MDIO_BUS_STATS_SHOW(errors, "%llu");
^
drivers/net/phy/mdio_bus.c:296:21: note: in definition of macro 'MDIO_BUS_STATS_SHOW_NAME'
len = sprintf(buf, format_string ## "\n", tmp); \
^~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c:306:1: note: in expansion of macro 'MDIO_BUS_STATS_SHOW'
MDIO_BUS_STATS_SHOW(errors, "%llu");
^~~~~~~~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c: In function 'mdio_bus_stats_writes_show':
drivers/net/phy/mdio_bus.c:307:29: error: pasting ""%llu"" and ""\n"" does not give a valid preprocessing token
MDIO_BUS_STATS_SHOW(writes, "%llu");
^
drivers/net/phy/mdio_bus.c:296:21: note: in definition of macro 'MDIO_BUS_STATS_SHOW_NAME'
len = sprintf(buf, format_string ## "\n", tmp); \
^~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c:307:1: note: in expansion of macro 'MDIO_BUS_STATS_SHOW'
MDIO_BUS_STATS_SHOW(writes, "%llu");
^~~~~~~~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c: In function 'mdio_bus_stats_reads_show':
drivers/net/phy/mdio_bus.c:308:28: error: pasting ""%llu"" and ""\n"" does not give a valid preprocessing token
MDIO_BUS_STATS_SHOW(reads, "%llu");
^
drivers/net/phy/mdio_bus.c:296:21: note: in definition of macro 'MDIO_BUS_STATS_SHOW_NAME'
len = sprintf(buf, format_string ## "\n", tmp); \
^~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c:308:1: note: in expansion of macro 'MDIO_BUS_STATS_SHOW'
MDIO_BUS_STATS_SHOW(reads, "%llu");
^~~~~~~~~~~~~~~~~~~
vim +305 drivers/net/phy/mdio_bus.c
300
301 #define MDIO_BUS_STATS_SHOW(field, format_string) \
302 MDIO_BUS_STATS_SHOW_NAME(field, __stringify(field), \
303 field, format_string)
304
> 305 MDIO_BUS_STATS_SHOW(transfers, "%llu");
306 MDIO_BUS_STATS_SHOW(errors, "%llu");
307 MDIO_BUS_STATS_SHOW(writes, "%llu");
308 MDIO_BUS_STATS_SHOW(reads, "%llu");
309
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28745 bytes --]
prev parent reply other threads:[~2020-01-14 4:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 4:53 [PATCH net-next] net: phy: Maintain MDIO device and bus statistics Florian Fainelli
2020-01-13 4:55 ` Florian Fainelli
2020-01-13 13:21 ` Andrew Lunn
2020-01-13 18:00 ` Florian Fainelli
2020-01-13 18:29 ` Andrew Lunn
2020-01-14 4:44 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001141253.BsdyxzQs%lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).